Updated layout notification to include properties #4944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
jwoo-msft
force-pushed
the
jwoo/ios-modified-layout-update
branch
from
489f3c0 to
d3303b4
Compare
|
Hi @jwoo-msft; Thanks for taking action on your previously stale pull request. Resetting staleness. |
almedina-ms
requested changes
Oct 27, 2020
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRAggregateTarget.mm
Show resolved
Hide resolved
source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizer/ViewController.m
Show resolved
Hide resolved
almedina-ms
approved these changes
Oct 27, 2020
jwoo-msft
added a commit
that referenced
this pull request
Oct 27, 2020
* updated target registration to allow for custom targets * Added registration for event handler * Added sample code * work in progress * Refactored Aggregate Target for re-use * updated codes * updated sample code * Updated layout notification to include properties (#4944) * added a new delegate method * Updated the usage
jwoo-msft
added a commit
that referenced
this pull request
Oct 27, 2020
* updated target registration to allow for custom targets * Added registration for event handler * Added sample code * work in progress * Refactored Aggregate Target for re-use * updated codes * updated sample code * Updated layout notification to include properties (#4944) * added a new delegate method * Updated the usage
jwoo-msft
added a commit
that referenced
this pull request
Oct 27, 2020
* updated target registration to allow for custom targets * Added registration for event handler * Added sample code * work in progress * Refactored Aggregate Target for re-use * updated codes * updated sample code * Updated layout notification to include properties (#4944) * added a new delegate method * Updated the usage
|
🎉 Handy links: |
ghost
mentioned this pull request
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* updated target registration to allow for custom targets * Added registration for event handler * Added sample code * work in progress * Refactored Aggregate Target for re-use * updated codes * updated sample code * Updated layout notification to include properties (microsoft#4944) * added a new delegate method * Updated the usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #4890
Description
Added layout update notification to include custom properties, so the user of this delegate include custom properties to enable them to do things like setting an input view or a label to be focused. The sample app can scroll to the correct input view with additional param passed from the notification.
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow