Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][Accessibility] [Successful submit action puts the focus on next card/element in chat] #5018

Closed
1 task
dipja opened this issue Nov 3, 2020 · 5 comments · Fixed by #5026
Closed
1 task

[Android][Accessibility] [Successful submit action puts the focus on next card/element in chat] #5018

dipja opened this issue Nov 3, 2020 · 5 comments · Fixed by #5026
Assignees
@golddove
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Milestone
20.11-12

Comments

@dipja
Copy link
Collaborator

dipja commented Nov 3, 2020 •
edited
Loading

Platform

What platform is your issue or question related to? (Delete other platforms).

  • Android

Author or host

Microsoft Teams

Version of SDK

2.3.0

Details

On successful submit action, the focus goes to the next available element/card in Teams chat. The sdk currently tries to clear the focus (Util.clearFocus() ) currently on submission of an action. This is leading to focus issue.

Video recording for the experience.
@dipja dipja added the Bug label Nov 3, 2020
@ghost ghost added this to the 20.11 milestone Nov 3, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Nov 3, 2020
@ghost
Copy link

ghost commented Nov 3, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@shalinijoshi19 shalinijoshi19 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner labels Nov 3, 2020
@ghost ghost removed the Triage-Needed label Nov 3, 2020
@ghost
Copy link

ghost commented Nov 3, 2020

Hi @dipja. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@ghost ghost added the Triage-Investigate label Nov 3, 2020
@golddove golddove mentioned this issue Nov 3, 2020
Merged
@ghost ghost added the Status-In Code Review label Nov 3, 2020
@golddove
Copy link
Member

golddove commented Nov 3, 2020

On successful submit, because we cleared focus, Android automatically moves focus to another input if there is one. In Teams' case, that is the next Adaptive Card.

Fix: don't cleat focus on successful submit.

@ghost
Copy link

ghost commented Nov 5, 2020

🎉AdaptiveCards@2020.10.1 has been released which fixes this issue.:tada:

Handy links:

@ghost ghost added the AdaptiveCards v20.11 label Nov 5, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

🎉AdaptiveCards@2020.12 has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@golddove golddove

Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Projects
None yet
Milestone
20.11-12
Development

Successfully merging a pull request may close this issue.

[Android] Avoid erratic scrolling on submit microsoft/AdaptiveCards
4 participants
@golddove @shalinijoshi19 @almedina-ms @dipja