[Android] Avoid erratic scrolling on submit #5026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
almedina-ms
reviewed
Nov 4, 2020
...ptivecards/src/main/java/io/adaptivecards/renderer/inputhandler/CheckBoxSetInputHandler.java
Show resolved
Hide resolved
almedina-ms
approved these changes
Nov 4, 2020
golddove
added a commit
that referenced
this pull request
Nov 4, 2020
* Request focus from touch * Clear focus only on invalid input * Don't clear focus * Removed commented lines * Update javadoc
golddove
added a commit
that referenced
this pull request
Nov 4, 2020
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Request focus from touch * Clear focus only on invalid input * Don't clear focus * Removed commented lines * Update javadoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5018
Fixes #5019
Description
Do not clear focus explicitly on submit. This avoids erratic scrolling on submit when multiple cards are in a recyclerview.
Known issue: If the first invalid input was already in focus before submit, it will not scroll into view.
How Verified
Manual testing of several cards in
mobilechatappv1.3/Scenarios/InputsWithValidation.json:Microsoft Reviewers: Open in CodeFlow