Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Cherrypick for 5026 #5038

Closed
wants to merge 17 commits into from
Closed

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Nov 4, 2020

Related Issue

Cherry-picks PR #5026

Microsoft Reviewers: Open in CodeFlow

RebeccaAnne and others added 17 commits October 27, 2020 09:11
…out text shorthand (#4910)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
* updated target registration to allow for custom targets

* Added registration for event handler

* Added sample code

* work in progress

* Refactored Aggregate Target for re-use

* updated codes

* updated sample code

* Updated layout notification to include properties (#4944)

* added a new delegate method

* Updated the usage
…4979)

Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>

Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
* Update versions for release

* Update minor version in custom props
* [Android] Switch pipelines to use Windows hosted pools (#4987)

* Use Microsoft's Windows hosted agent pools

* .bat extension for Windows

* Explicit pool name

* Remove sudo, because Windows

* Windows-style path, because Windows

* Trying with cmd script

* Fix path

* syntax

* Disable get ndk

* daily too

* [Samples][Accessibility] TextBlock wrap in Scenario cards (#4991)

* Text: wrap for scenario samples

* Copyright, license

* More wrap

* Missed some

* Spaces for indentation

Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>

* [Android] Fix rendering of inputs with no labels (#4995)

* Fix rendering of inputs with no labels

* Fix error messages for missing labels too

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
…om release script (#5009)

* Fixing 1 high pri vulnerability and also removing the typeDoc step from our release script for now since it's failing

* Removing extraneous dts dependency
* [Android][Accessibility] Fix Inputs not receiving focus (#5028)

* Allow focus

* Add fix for compact choicesets

* Update input layout to support layouts with spinners

* Replace lines for premade method

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>

* Fix basic behaviour (#5029)

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
* Request focus from touch

* Clear focus only on invalid input

* Don't clear focus

* Removed commented lines

* Update javadoc
* Reverts ChoiceSet Xib changes

* Updated accessibility focus

* TextField Input Label View update

* code clean-up before CR

* updated to better format

* changed set to holde weak references to UIView

* updated unit test
* Reverts ChoiceSet Xib changes

* Updated accessibility focus

* TextField Input Label View update

* code clean-up before CR

Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
@ghost
Copy link

ghost commented Nov 4, 2020

Hi @almedina-ms. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@almedina-ms almedina-ms closed this Nov 4, 2020
@golddove golddove deleted the user/almedina-ms/golddove-CP branch November 4, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants