Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][Accessibility] [On input validation failure focus does not go to the first invalid input field when the first invalid field is date/time/compact choiceset] #5020

Closed
1 task
dipja opened this issue Nov 3, 2020 · 4 comments · Fixed by #5028
Closed
1 task

[Android][Accessibility] [On input validation failure focus does not go to the first invalid input field when the first invalid field is date/time/compact choiceset] #5020

dipja opened this issue Nov 3, 2020 · 4 comments · Fixed by #5028
Assignees
@almedina-ms
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Milestone
20.11-12

Comments

@dipja
Copy link
Collaborator

dipja commented Nov 3, 2020

Platform

What platform is your issue or question related to? (Delete other platforms).

  • Android

Author or host

Microsoft Teams

Version of SDK

2.3.0

Details

On input validation failure focus does not go to the first invalid input field when the first invalid input field is date/time/compact choiceset.
@dipja dipja added the Bug label Nov 3, 2020
@ghost ghost added this to the 20.11 milestone Nov 3, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Nov 3, 2020
@ghost
Copy link

ghost commented Nov 3, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@shalinijoshi19 shalinijoshi19 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner labels Nov 3, 2020
@ghost ghost removed the Triage-Needed label Nov 3, 2020
@ghost
Copy link

ghost commented Nov 3, 2020

Hi @dipja. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@ghost ghost added the Triage-Investigate label Nov 3, 2020
@shalinijoshi19
Copy link
Member

@almedina-ms to help look into this specifically around compact choiceset elements.

@almedina-ms almedina-ms mentioned this issue Nov 3, 2020
Merged
@ghost ghost added the Status-In Code Review label Nov 3, 2020
This was referenced Nov 4, 2020
Closed
Closed
@almedina-ms almedina-ms reopened this Nov 4, 2020
@ghost ghost added the Triage-Needed label Nov 4, 2020
@ghost ghost removed the Triage-Investigate label Nov 4, 2020
@almedina-ms almedina-ms mentioned this issue Nov 4, 2020
Merged
almedina-ms added a commit that referenced this issue Nov 4, 2020
@almedina-ms @golddove
[Android] Cherrypick of fixes for #5020 and #5021 (#5031)
15808bf 
* [Android][Accessibility] Fix Inputs not receiving focus (#5028)

* Allow focus

* Add fix for compact choicesets

* Update input layout to support layouts with spinners

* Replace lines for premade method

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>

* Fix basic behaviour (#5029)

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
@ghost
Copy link

ghost commented Nov 5, 2020

🎉AdaptiveCards@2020.10.1 has been released which fixes this issue.:tada:

Handy links:

@ghost ghost added the AdaptiveCards v20.11 label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@almedina-ms almedina-ms

Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Projects
None yet
Milestone
20.11-12
Development

Successfully merging a pull request may close this issue.

[Android][Accessibility] Fix Inputs not receiving focus microsoft/AdaptiveCards
4 participants
@golddove @shalinijoshi19 @almedina-ms @dipja