Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Target Builder Director Interface #5008

Merged
merged 9 commits into from
Nov 4, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Oct 30, 2020

Related Issue && Description

Fixed #5025
The target builder director's interface exposes C++ interfaces, and these changes wrap the interface with the objective-c version.

How Verified

How you verified the fix, including one or all of the following:

  1. Existing Unit tests & tested with sample cards for regression
  2. Manual scenario verification if any; ***Do include .gif's or screenshots of the testing you performed here if you think that it
Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft force-pushed the jwoo/ios-target-builder-director-update branch from e4f11c4 to 08b46d7 Compare November 4, 2020 03:32
@jwoo-msft jwoo-msft changed the base branch from main to jwoo/ios-input-choiceset November 4, 2020 03:35
@shalinijoshi19
Copy link
Member

@jwoo-msft there seems to be sort of an issue with the iOS/UWP CI pipelines - @golddove ideas on why we are seeing duplicate pipelines run (nightly and CI) both?

Base automatically changed from jwoo/ios-input-choiceset to main November 4, 2020 17:35
@jwoo-msft
Copy link
Member Author

@jwoo-msft there seems to be sort of an issue with the iOS/UWP CI pipelines - @golddove ideas on why we are seeing duplicate pipelines run (nightly and CI) both?

the build pipeline result here ran 6 days ago, it seems fine now.

…Microsoft/AdaptiveCards into jwoo/ios-target-builder-director-update
@jwoo-msft jwoo-msft merged commit 288fa09 into main Nov 4, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-target-builder-director-update branch November 4, 2020 18:13
jwoo-msft added a commit that referenced this pull request Nov 4, 2020
* Reverts ChoiceSet Xib changes

* Updated accessibility focus

* TextField Input Label View update

* code clean-up before CR

* updated to better format

* changed set to holde weak references to UIView

* updated unit test
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* Reverts ChoiceSet Xib changes

* Updated accessibility focus

* TextField Input Label View update

* code clean-up before CR

* updated to better format

* changed set to holde weak references to UIView

* updated unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Custom Action] [ Can not send additional properties to action delegates in case of custom action]
3 participants