-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Target Builder Director Interface #5008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4f11c4
to
08b46d7
Compare
@jwoo-msft there seems to be sort of an issue with the iOS/UWP CI pipelines - @golddove ideas on why we are seeing duplicate pipelines run (nightly and CI) both? |
the build pipeline result here ran 6 days ago, it seems fine now. |
golddove
approved these changes
Nov 4, 2020
…Microsoft/AdaptiveCards into jwoo/ios-target-builder-director-update
jwoo-msft
added a commit
that referenced
this pull request
Nov 4, 2020
* Reverts ChoiceSet Xib changes * Updated accessibility focus * TextField Input Label View update * code clean-up before CR * updated to better format * changed set to holde weak references to UIView * updated unit test
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Reverts ChoiceSet Xib changes * Updated accessibility focus * TextField Input Label View update * code clean-up before CR * updated to better format * changed set to holde weak references to UIView * updated unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue && Description
Fixed #5025
The target builder director's interface exposes C++ interfaces, and these changes wrap the interface with the objective-c version.
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow