Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Schema] Update default schema link to use the 1.3.0 schema #4968

Merged
merged 4 commits into from
Oct 28, 2020
Merged

[Schema] Update default schema link to use the 1.3.0 schema #4968

merged 4 commits into from
Oct 28, 2020

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Oct 26, 2020 •
edited by ghost
Loading

Related Issue

Fixes #4884

Description

Update the unversioned schema path to point to the current 1.3 version of the schema. Further discussion of handling of versioned schemas is still tracked by #4879.

How Verified

Built website and confirmed that the schema path was pointed to the latest version.

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Oct 26, 2020

Hi @RebeccaAnne. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@RebeccaAnne RebeccaAnne merged commit 2360bce into main Oct 28, 2020
@RebeccaAnne RebeccaAnne deleted the rebecch/schemaVersion branch October 28, 2020 15:57
RebeccaAnne pushed a commit that referenced this pull request Oct 28, 2020
@shalinijoshi19
[Schema] Update default schema link to use the 1.3.0 schema (#4968)
3401560 
Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
@RebeccaAnne RebeccaAnne mentioned this pull request Oct 28, 2020
Merged
RebeccaAnne pushed a commit that referenced this pull request Oct 28, 2020
@shalinijoshi19
[Schema] Update default schema link to use the 1.3.0 schema (#4968) (#…
96be805 
…4979)

Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>

Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
@ghost
Copy link

ghost commented Oct 31, 2020

🎉AdaptiveCards@2020.10 has been released which fixes this issue.:tada:

Handy links:

@ghost ghost mentioned this pull request Oct 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalinijoshi19 shalinijoshi19 shalinijoshi19 approved these changes

@matthidinger matthidinger Awaiting requested review from matthidinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Site] Update unversioned schema file on site
2 participants
@RebeccaAnne @shalinijoshi19