Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Streamline Android publishing #4541

Merged
merged 6 commits into from
Aug 18, 2020
Merged

[Android] Streamline Android publishing #4541

merged 6 commits into from
Aug 18, 2020

Conversation

golddove
Copy link
Member

@golddove golddove commented Aug 5, 2020 •
edited by ghost
Loading

Related Issue

No issue filed, but our current release pom's don't declare dependencies.

Description

  • Update build.gradle to use the component generated by android for publishing (refer to Android's recommendation here.
  • Setup local and ADO publishing repositories to support generating artifact to local directory or to ADO feed (or both).
  • Move Android's daily pipeline to .pipelines/android-daily.yml

How Verified

Needs verification. Not ready for merge.

Microsoft Reviewers: Open in CodeFlow

@golddove golddove marked this pull request as ready for review August 6, 2020 04:42
@ghost ghost added the no-recent-activity label Aug 11, 2020
@ghost ghost assigned almedina-ms Aug 11, 2020
@ghost
Copy link

ghost commented Aug 11, 2020

Hi @golddove. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Aug 12, 2020 •
edited
Loading

@golddove is this the approach we are going with or is it #4538 or are the 2 needed together?

@ghost ghost removed the no-recent-activity label Aug 12, 2020
@ghost
Copy link

ghost commented Aug 12, 2020

Hi @shalinijoshi19; Thanks for commenting on this previously stale pull request. Resetting staleness. @golddove FYI.

@ghost ghost added the no-recent-activity label Aug 17, 2020
@ghost ghost assigned paulcam206 Aug 17, 2020
@ghost
Copy link

ghost commented Aug 17, 2020

Hi @golddove. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

almedina-ms
almedina-ms requested changes Aug 18, 2020
View reviewed changes
.pipelines/android-daily.yml
@@ -0,0 +1,57 @@
name: $(Year:yyyy).$(Month).$(DayOfMonth)-$(rev:r)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this file here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the yml version of the Android daily pipeline. It will not delete the existing pipeline, but once it is checked into main, we can see if it is working as expected.

@ghost ghost removed the no-recent-activity label Aug 18, 2020
@ghost
Copy link

ghost commented Aug 18, 2020

Hi @almedina-ms; Thanks for reviewing this previously stale pull request. Resetting staleness. @golddove FYI.

@ghost
Copy link

ghost commented Aug 18, 2020

Hi @almedina-ms; Thanks for reviewing this previously stale pull request. Resetting staleness. @golddove FYI.

@almedina-ms almedina-ms mentioned this pull request Aug 18, 2020
Closed
@golddove golddove merged commit 2e17238 into main Aug 18, 2020
@golddove golddove deleted the golddove/pom branch August 18, 2020 21:14
golddove added a commit that referenced this pull request Aug 31, 2020
@golddove @almedina-ms
[Android] Streamline Android publishing (#4541)
19f364d 
* Use gradle for dependencies

* Android Daily pipeline

* Remove trailing zeros from version number

* Disable ci/pr triggers

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
@golddove golddove mentioned this pull request Aug 31, 2020
Merged
golddove added a commit that referenced this pull request Aug 31, 2020
@golddove @almedina-ms
[Android] Cherry-pick Gradle changes (#4710)
dbeb2d9 
* [Android] Streamline Android publishing (#4541)

* Use gradle for dependencies

* Android Daily pipeline

* Remove trailing zeros from version number

* Disable ci/pr triggers

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>

* Update gradlew

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
@ghost
Copy link

ghost commented Sep 1, 2020

🎉AdaptiveCards@1.2.12 has been released which fixes this issue.:tada:

Handy links:

@golddove golddove added this to the 20.08 milestone Mar 3, 2021
@ghost ghost removed the Needs: Author Feedback label Mar 3, 2021
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@golddove @almedina-ms
[Android] Streamline Android publishing (microsoft#4541)
c731656 
* Use gradle for dependencies

* Android Daily pipeline

* Remove trailing zeros from version number

* Disable ci/pr triggers

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcam206 paulcam206 paulcam206 approved these changes

@almedina-ms almedina-ms almedina-ms approved these changes

@jwoo-msft jwoo-msft Awaiting requested review from jwoo-msft

@shalinijoshi19 shalinijoshi19 Awaiting requested review from shalinijoshi19

Assignees

@paulcam206 paulcam206

@almedina-ms almedina-ms

Labels
None yet
Projects
None yet
Milestone
20.08
Development

Successfully merging this pull request may close these issues.
4 participants
@golddove @shalinijoshi19 @paulcam206 @almedina-ms