Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Designer] Set focus on first card in card catalog when it loads #4562

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Aug 10, 2020

Related Issue

Fixes VSO #24068357

Description

I previously fixed a bunch of accessibility issues around the "New card" dialog, but missed setting keyboard focus on the first card in the catalog.

How Verified

  • local build/validation
Microsoft Reviewers: Open in CodeFlow

@paulcam206 paulcam206 requested a review from dclaux August 10, 2020 21:31
@ghost
Copy link

ghost commented Aug 10, 2020

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@paulcam206 paulcam206 added Area-Accessibility Bugs around feature accessibility Area-Designer Platform-JavaScript Bugs or features related to the JavaScript renderer labels Aug 10, 2020
@paulcam206 paulcam206 merged commit f0fcae7 into main Aug 12, 2020
@paulcam206 paulcam206 deleted the paulcam/new-card-keyboard-focus branch August 12, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Area-Designer Platform-JavaScript Bugs or features related to the JavaScript renderer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant