Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #4843 #4920

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Fixed #4843 #4920

merged 2 commits into from
Oct 21, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Oct 14, 2020

Related Issue

Fixed #4843

Description

Without explicitly writing hidden property for UIView resulted in a super view to change its hidden value to same as its subview. For example, if subview changed its hidden status to true, superview will change its value to hidden as well. Made the change so, hidden value will be explicitly set.

How Verified

  1. Ran the test card
  2. Checked existing cards
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Oct 19, 2020
@ghost ghost assigned paulcam206 Oct 19, 2020
@ghost
Copy link

ghost commented Oct 19, 2020

Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Oct 21, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

Hi @golddove; Thanks for reviewing this previously stale pull request. Resetting staleness. @jwoo-msft FYI.

@jwoo-msft jwoo-msft merged commit ce59ca5 into main Oct 21, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-isVisible branch October 21, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Issue with isVisibility] [isVisibility for an item in Container gets imposed on other items]
3 participants