Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Separator #4921

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Updated Separator #4921

merged 3 commits into from
Oct 22, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Oct 14, 2020

Related Issue

Fixed #4900

Description

The separator takes value from its previous element, but it was reading the value from the current element.

How Verified

How you verified the fix, including one or all of the following:

  1. Test card was run and verified
  2. Scenario cards are run
  3. Pending on more regression tests.
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Oct 20, 2020
@ghost ghost assigned paulcam206 Oct 20, 2020
@ghost
Copy link

ghost commented Oct 20, 2020

Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

Copy link
Contributor

@RebeccaAnne RebeccaAnne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost removed the no-recent-activity label Oct 21, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

Hi @RebeccaAnne; Thanks for reviewing this previously stale pull request. Resetting staleness. @jwoo-msft FYI.

@jwoo-msft jwoo-msft merged commit 50741fc into main Oct 22, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-separator branch October 22, 2020 00:04
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* Updated Separator

* Finalized the fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants