Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an accessibility issue #5131

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Dec 5, 2020

Related Issue

Fixed an accessibility ADO issue: https://microsoft.visualstudio.com/OS/_queries/edit/29528039/?triage=true

Description

After input is chosen for the date, VoiceOver focus gets lost, and this PR will fix the issue.

Sample Card

https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.1/Tests/ColumnSet.Input.Date.VerticalStretch.json

How Verified

How you verified the fix, including one or all of the following:

  1. Existing relevant unit/regression tests that you ran; ran all unit tests.
  2. Manual scenario verification if any; Do include .gif's or screenshots of the testing you performed here if you think that it
    will aid in code reviews or corresponding fixes on other platforms for eg.

    ezgif com-gif-maker
    https://gifs.com/gif/input-vlElR0
Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft merged commit 09bd0db into main Dec 9, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-input-accessibility-update branch December 9, 2020 02:25
@shalinijoshi19 shalinijoshi19 added this to the 20.11-12 milestone Dec 11, 2020
@ghost ghost added the AdaptiveCards v20.12 label Dec 11, 2020
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants