[NodeJS Templating] Enable host parameters #7199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into enableHostParameters
…into enableHostParameters
anna-dingler
requested review from
jwoo-msft,
licanhua,
paulcam206,
beervoley and
almedina-ms
|
Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
licanhua
reviewed
Apr 7, 2022
paulcam206
requested changes
Apr 7, 2022
ghost
added
the
paulcam206
reviewed
Apr 7, 2022
licanhua
approved these changes
Apr 7, 2022
licanhua
reviewed
Apr 11, 2022
This reverts commit 7cd2f1f.
almedina-ms
approved these changes
Apr 11, 2022
paulcam206
approved these changes
Apr 13, 2022
licanhua
reviewed
Apr 13, 2022
anna-dingler
added a commit
that referenced
this pull request
May 11, 2022
* Change cursor to pointer when hover on action * Move cursor change out of hover state * In progress: update templating * Fix formatting * Update templating unit tests * Formatting * Refactor templating unit tests * Formatting * Add additional templating tests * Bump templating version * Revert "Bump templating version" This reverts commit 7cd2f1f.
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Change cursor to pointer when hover on action * Move cursor change out of hover state * In progress: update templating * Fix formatting * Update templating unit tests * Formatting * Refactor templating unit tests * Formatting * Add additional templating tests * Bump templating version * Revert "Bump templating version" This reverts commit 7cd2f1f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow card author to supply
$hostdata in addition to$rootdata.I added
$hostvariable toIEvaluationContextandTemplateObjectMemoryso that binding with${$host.keyHere}will search through the provided$hostJSON.Sample Card
An example card can be found at:
source/nodejs/tests/unit-tests/template-test-resources/complex-template-host.jsonHow Verified
Added new unit tests to
source/nodejs/tests/unit-testsfor the templating library.Microsoft Reviewers: Open in CodeFlow