Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP Renderer] Update min/max handling for inputs #8236

Merged
merged 9 commits into from
Feb 23, 2023
Merged

[UWP Renderer] Update min/max handling for inputs #8236

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1e0f72a
Switch to gotFocus (#8148) (#8150)
anna-dingler Dec 16, 2022
61db685
Update custom.props
jwoo-msft Dec 16, 2022
0593d95
[UWP] Update custom.props for object model release (#8225)
anna-dingler Jan 13, 2023
90b97be
[UWP Renderer] Add a null check to inline action rendering (#8228)
anna-dingler Jan 13, 2023
85676f6
Update min/max handling for inputs
anna-dingler Jan 17, 2023
2000d3a
[UWP][Infra] Update nuget files for release (#6576) (#8240)
anna-dingler Jan 18, 2023
ca64ff0
Merge branch 'release/uwp-v3.1.0' into anna/inputValueMinMax
beervoley Jan 27, 2023
7127bfc
Resolve merge conflicts
anna-dingler Feb 22, 2023
adf067b
Merge branch 'main' into anna/inputValueMinMax
anna-dingler Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/uwp/SharedRenderer/lib/InputValue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,13 +184,13 @@ namespace winrt::AdaptiveCards::Rendering::Xaml_Rendering
if (max)
{
double maxDouble = max.Value();
isValid = (currentDouble <= maxDouble);
isValid &= (currentDouble <= maxDouble);
}

if (min)
{
double minDouble = min.Value();
isValid = (currentDouble >= minDouble);
isValid &= (currentDouble >= minDouble);
}
}
catch (...)
Expand Down Expand Up @@ -278,7 +278,7 @@ namespace winrt::AdaptiveCards::Rendering::Xaml_Rendering
unsigned int minHours, minMinutes;
if (::AdaptiveCards::DateTimePreparser::TryParseSimpleTime(minTimeStdString, minHours, minMinutes))
{
winrt::TimeSpan minTime{(int64_t)(minHours * 60 + minMinutes) * 1000000 * 60};
winrt::TimeSpan minTime{(int64_t)(minHours * 60 + minMinutes) * 10000000 * 60};
isMaxMinValid &= currentTime.count() >= minTime.count();
}
}
Expand Down