Fixed Overflow action button not announcing view chagnes #8721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #8654.
Description
As focus is moved to a menu overlay from a button, buttons aria-expanded state is not announced by voice over. moved the aria-expanded to menu item itself, where the focus is set. When menu item closes, have the focus to be back on the button with aria-expanded set to false. however, with keyboard navigation, when 'return' key is used to close the menu item, it will trigger click event on the button when the focus is back to the button. In order to stop such behavior, preventDefault() was used.
Sample Card
N/A
How Verified
Manually verified.