[XAML] Fix for exception thrown in WholeItemsPanel
#8839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a simple mistake in the conversion to cppwinrt (
as
vs.try_as
). The converted version would throw instead of quietly skipping the check...original
AdaptiveCards/source/uwp/Renderer/lib/WholeItemsPanel.cpp
Lines 469 to 478 in d608411
converted
AdaptiveCards/source/uwp/Renderer/lib/WholeItemsPanel.cpp
Lines 357 to 363 in 1dcef8c