Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP/WinUI3] Refactor Image Rendering #8896

Merged
merged 8 commits into from
May 3, 2024
Merged

[UWP/WinUI3] Refactor Image Rendering #8896

merged 8 commits into from
May 3, 2024

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Apr 30, 2024

Related Issue

Refactored Image loading.

Description

Changed image loading from completion callback routine to co_routine.

Sample Card

If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.

How Verified

Verified with all of the sample and test image jsons.
image
image

@jwoo-msft jwoo-msft requested a review from almedina-ms May 3, 2024 17:37
anna-dingler
anna-dingler previously approved these changes May 3, 2024
paulcam206
paulcam206 previously approved these changes May 3, 2024
source/uwp/SharedRenderer/lib/AdaptiveImageRenderer.cpp Outdated Show resolved Hide resolved
source/uwp/SharedRenderer/lib/AdaptiveImageRenderer.cpp Outdated Show resolved Hide resolved
@jwoo-msft jwoo-msft dismissed stale reviews from paulcam206 and anna-dingler via a3670e9 May 3, 2024 23:25
@jwoo-msft jwoo-msft merged commit 2780d6a into main May 3, 2024
6 of 7 checks passed
@jwoo-msft jwoo-msft deleted the jwoo/refactor_change branch May 3, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants