-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rpclib as a submodule and compile directly from source #16
Conversation
* Compiling from source allows better compatibility with alternative platforms
Hi @8W9aG, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Also would be grateful if people could test whether this still works on Windows as well (I think it should) |
$ git fetch origin pull/16/head:master (no errors) |
Inside of Unreal/Plugins/AirSim/readme.md it says "Create black C++ Unreal project without starter content", do you mean To select "New Project"-> "C++" -> "Basic Code"? |
Also for me on OSX, the suggested Modular Neighborhood Pack does not support the current Unreal Engine 4.15.0 is it OK to tell it to use the closest version being 4.14 when it asks? |
Yes you want Unreal 4.14 |
Thanks @lovettchris ... Sorry I am not an Unreal user... so next up we have "- Project Settings > Maps - set the map". I am as stated above using Modular Neighborhood Pack, What should I be setting for "Editor Startup Map", and "Game Default Map", "Default GameMode", and "Game Instance Class". These values are all greek to me, as is what it means to "set" a Map as it were, short of making it default. I just don't know if I want Template_Default, Demo_Map, Overview, or Also for anyone wondering this is how you can copy the plugins over: |
For OSX the instructions get a little odd here: "Ready, Set, Go! Is there any alternate wording for us? FWIW My project file was in: ~/Documents/Unreal\ Projects/AirSImProjectName/AirSImAirSImProjectName.uproject |
Hi @d13-kevinf The readme at Unreal/Plugins/AirSim/readme.md was old and has been deleted. If you are using Neighbourhood pack, set the Editor Starter Map as well as Game Default Map to Demo_Map in Project Settings > Maps & Modes. Don't change Default Game Mode in that screen. Go to World Settings and then set Game Mode = SimModeGame. On OSX you will need to generate XCode project files. May be below might answer your question: https://answers.unrealengine.com/questions/45320/how-to-create-xcodeproj-for-pc-started-project.html I'm also looking at your PR. Please also free free to submit osx_build.md with steps you followed so far. |
I've pushed this change with slightly different variation.
So, in essence, the folder structure under AirLib/deps remains same so no other changes are required. I've tested build in Windows however not under Linux yet due to GCC upgrade issue on my current machine. It would be great if you get chance to try it out or if you have any suggestion for any alternative way to achieve above in CMakeLists.txt. |
This fixes the OSX linker issues when dealing with rpclib.
As a sidenote, I'm not sure whether you want to use the git subtree or submodule workflow here.