Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advisor Cost Optimization Workbook / March Updates #2598

Merged

Conversation

arthurclares
Copy link
Contributor

@arthurclares arthurclares commented Mar 14, 2024

PR Checklist

  • Explain your changes, so people looking at the PR know what and why, the code changes are the how.
    March Update:
  • Add queries to identify more idle resources
    -- NAT gateways
    -- Private Endpoints
    -- Private DNS
  • Improved Idle Disk query to show last modified date
  • Add a new tab for databases
    • Cosmos DB and SQL DB queries
  • Add a new tab for Sustainability
    • Carbon optimization query
  • Remove Savings chart
  • Fixed a bug on the SQL VM AHB query where it was not correctly showing SQL DBs with AHB enabled.
  • Validate your changes using one or more of the testing methods.

If adding or updating templates:

  • post a screenshot of templates and/or gallery changes
  • ensure your template has a corresponding gallery entry in the gallery folder
  • If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals
  • ensure all steps have meaningful names
  • ensure all parameters and grid columns have display names set so they can be localized
  • ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)
  • ensure that steps names are unique or they will fail PR validation (step names are used for localization)
  • grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validation
  • remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation

@arthurclares arthurclares requested a review from a team as a code owner March 14, 2024 21:57
@arthurclares arthurclares requested a review from sebassem March 18, 2024 21:29
@arthurclares
Copy link
Contributor Author

@sebassem can you please review and make sure all the tabs are working as expected?

Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkrishnanms pkrishnanms merged commit 1878ea0 into microsoft:master Mar 22, 2024
2 checks passed
@arthurclares arthurclares deleted the costoptimizationworkbook-march branch March 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants