Enable Security Analysis (CodeQL) for Policy Compliance (#1593)

.github/codeql/codeql-config.yml

@@ -0,0 +1,11 @@
+name: "CodeQL config"
+
+queries:
+  - uses: security-and-quality
+
+paths-ignore:
+  - '**/test/'
+  - '**/Tests/'
+  - '**/dist-history/'
+  - '**/rollup.config.js'
+  - '/extensions/applicationinsights-angularplugin-js/'

.github/workflows/codeql-analysis.yml

@@ -0,0 +1,72 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ master ]
+  schedule:
+    - cron: '17 15 * * 2'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'javascript' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
+        # Learn more:
+        # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v2
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v1
+      with:
+        languages: ${{ matrix.language }}
+        config-file: ./.github/codeql/codeql-config.yml
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+        # queries: ./path/to/local/query, your-org/your-repo/queries@main
+
+    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+    # If this step fails, then you should remove it and run the build manually (see below)
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v1
+
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 https://git.io/JvXDl
+
+    # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
+    #    and modify them (or add more) to build your code if your project
+    #    uses a compiled language
+
+    #- run: |
+    #   make bootstrap
+    #   make release
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v1

channels/applicationinsights-channel-js/src/Offline.ts

@@ -31,7 +31,7 @@ export class OfflineListener {
 
                     if (!isUndefined(target.ononline)) {
                         target.ononline = _setOnline;
-                        target.onoffline = _setOffline
+                        target.onoffline = _setOffline;
                         isListening = true;
 
                     }

channels/applicationinsights-channel-js/src/Sender.ts

@@ -16,7 +16,7 @@ import {
     ITelemetryItem, IProcessTelemetryContext, IConfiguration,
     _InternalMessageId, LoggingSeverity, IDiagnosticLogger, IAppInsightsCore, IPlugin,
     getWindow, getNavigator, getJSON, BaseTelemetryPlugin, ITelemetryPluginChain, INotificationManager,
-    SendRequestReason, getGlobalInst, objForEachKey, isNullOrUndefined, arrForEach, dateNow, dumpObj, getExceptionName, getIEVersion, throwError, objKeys
+    SendRequestReason, getGlobalInst, objForEachKey, isNullOrUndefined, arrForEach, dateNow, dumpObj, getExceptionName, getIEVersion, throwError, objKeys, strUndefined
 } from '@microsoft/applicationinsights-core-js';
 import { Offline } from './Offline';
 import { Sample } from './TelemetryProcessors/Sample'
@@ -252,7 +252,7 @@ export class Sender extends BaseTelemetryPlugin implements IChannelControlsAI {
                         if ("withCredentials" in testXhr) {
                             _self._sender = _xhrSender;
                             _self._XMLHttpRequestSupported = true;
-                        } else if (typeof XDomainRequest !== undefined) {
+                        } else if (typeof XDomainRequest !== strUndefined) {
                             _self._sender = _xdrSender; // IE 8 and 9
                         }
                     } else {

channels/applicationinsights-channel-js/src/TelemetryProcessors/Sample.ts

@@ -21,7 +21,7 @@ export class Sample implements ISample {
                 _InternalMessageId.SampleRateOutOfRange,
                 "Sampling rate is out of range (0..100). Sampling will be disabled, you may be sending too much data which may affect your AI service level.",
                 { samplingRate: sampleRate }, true);
-            this.sampleRate = 100;
+            sampleRate = 100;
         }
 
         this.sampleRate = sampleRate;

extensions/applicationinsights-debugplugin-js/src/components/helpers.ts

@@ -61,9 +61,9 @@ export function traverseAndReplace(target: Object, maxDepth: number, currentDept
 
 function _sanitizeText(value: string) {
     if (value) {
-        value = value.replace('&', '&');
-        value = value.replace('>', '>');
-        value = value.replace('<', '&lt;');
+        value = value.replace(/&/g, '&amp;');
+        value = value.replace(/>/g, '&gt;');
+        value = value.replace(/</g, '&lt;');
     }
 
     return value;

extensions/applicationinsights-dependencies-js/src/ajax.ts

@@ -508,7 +508,7 @@ export class AjaxMonitor extends BaseTelemetryPlugin implements IDependenciesPlu
                             if (_isMonitoredXhrInstance(xhr) && !ajaxData.xhrMonitoringState.sendDone) {
                                 _createMarkId("xhr", ajaxData);
                                 ajaxData.requestSentTime = dateTimeUtilsNow();
-                                xhr = _self.includeCorrelationHeaders(ajaxData, undefined, undefined, xhr);
+                                _self.includeCorrelationHeaders(ajaxData, undefined, undefined, xhr);
                                 ajaxData.xhrMonitoringState.sendDone = true;
                             }
                         },

shared/AppInsightsCommon/src/Util.ts

@@ -363,7 +363,7 @@ export const CorrelationIdHelper: ICorrelationIdHelper = {
         if (includedDomains) {
             let matchExists: boolean;
             arrForEach(includedDomains, (domain) => {
-                const regex = new RegExp(domain.toLowerCase().replace(/\./g, "\.").replace(/\*/g, ".*"));
+                const regex = new RegExp(domain.toLowerCase().replace(/\\/g, "\\\\").replace(/\./g, "\\.").replace(/\*/g, ".*"));
                 matchExists = matchExists || regex.test(requestHost);
             });
 
@@ -378,7 +378,7 @@ export const CorrelationIdHelper: ICorrelationIdHelper = {
         }
 
         for (let i = 0; i < excludedDomains.length; i++) {
-            const regex = new RegExp(excludedDomains[i].toLowerCase().replace(/\./g, "\.").replace(/\*/g, ".*"));
+            const regex = new RegExp(excludedDomains[i].toLowerCase().replace(/\\/g, "\\\\").replace(/\./g, "\\.").replace(/\*/g, ".*"));
             if (regex.test(requestHost)) {
                 return false;
             }

shared/AppInsightsCore/src/JavaScriptSDK/CookieMgr.ts

@@ -92,8 +92,8 @@ export function safeGetCookieMgr(core: IAppInsightsCore, config?: IConfiguration
     if (core) {
         // Always returns an instance
         cookieMgr = core.getCookieMgr();
-    } else if(config) {
-        let cookieCfg = (config ||{}).cookieCfg;
+    } else if (config) {
+        let cookieCfg = config.cookieCfg;
         if (cookieCfg[strConfigCookieMgr]) {
             cookieMgr = cookieCfg[strConfigCookieMgr];
         } else {

shared/AppInsightsCore/src/JavaScriptSDK/DiagnosticLogger.ts

@@ -107,7 +107,7 @@ export class DiagnosticLogger implements IDiagnosticLogger {
                 if (_self.enableDebugExceptions()) {
                     throw message;
                 } else {
-                    if (!isUndefined(message) && !!message && !isUndefined(message.message)) {
+                    if (!isUndefined(message.message)) {
                         const logLevel = _self.consoleLoggingLevel();
                         if (isUserAct) {
                             // check if this message type was already logged to console for this page view and if so, don't log it again

shared/AppInsightsCore/src/JavaScriptSDK/PerfManager.ts

@@ -228,7 +228,7 @@ const doPerfActiveKey = "CoreUtils.doPerf";
 export function doPerf<T>(mgrSource: IPerfManagerProvider | IPerfManager, getSource: () => string, func: (perfEvt?: IPerfEvent) => T, details?: () => any, isAsync?: boolean) {
     if (mgrSource) {
         let perfMgr: IPerfManager = mgrSource as IPerfManager;
-        if (perfMgr && isFunction(perfMgr["getPerfMgr"])) {
+        if (isFunction(perfMgr["getPerfMgr"])) {
             // Looks like a perf manager provider object
             perfMgr = perfMgr["getPerfMgr"]()
         }

tools/release-tools/setVersion.js

@@ -157,8 +157,7 @@ function calculateVersion(rootVersion) {
         parts = ["0", "0", "0"];
     }
 
-    // Set the default version to the current
-    newVersion = preRelParts[0];
+    let newVersion;
 
     if (newVer) {
         newVersion = newVer;