[BUG] When using Multiple instances of AI only the first instance is …

…correctly reporting ajax events #1655 (#1686)
microsoft · Oct 6, 2021 · 25e8375 · 25e8375
1 parent 401bd3c
commit 25e8375
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/extensions/applicationinsights-dependencies-js/src/ajax.ts b/extensions/applicationinsights-dependencies-js/src/ajax.ts
@@ -497,9 +497,14 @@ export class AjaxMonitor extends BaseTelemetryPlugin implements IDependenciesPlu
                         req: (args:IInstrumentCallDetails, method:string, url:string, async?:boolean) => {
                             let xhr = args.inst as XMLHttpRequestInstrumented;
                             let ajaxData = xhr[strAjaxData];
-                            if (!_isDisabledRequest(xhr, url) && _isMonitoredXhrInstance(xhr, true) &&
-                                    (!ajaxData || !ajaxData.xhrMonitoringState.openDone)) {
-                                _openHandler(xhr, method, url, async);
+                            if (!_isDisabledRequest(xhr, url) && _isMonitoredXhrInstance(xhr, true)) {
+                                if (!ajaxData || !ajaxData.xhrMonitoringState.openDone) {
+                                    // Only create a single ajaxData (even when multiple AI instances are running)
+                                    _openHandler(xhr, method, url, async);
+                                }
+
+                                // always attach to the on ready state change (required for handling multiple instances)
+                                _attachToOnReadyStateChange(xhr);
                             }
                         },
                         hkErr: _createErrorCallbackFunc(_self, _InternalMessageId.FailedMonitorAjaxOpen,
@@ -643,8 +648,6 @@ export class AjaxMonitor extends BaseTelemetryPlugin implements IDependenciesPlu
                 ajaxData.async = async;
                 ajaxData.errorStatusText = _enableAjaxErrorStatusText;
                 xhr[strAjaxData] = ajaxData;
-
-                _attachToOnReadyStateChange(xhr);
             }
 
             function _attachToOnReadyStateChange(xhr: XMLHttpRequestInstrumented) {