Merge pull request #341 from Microsoft/AiStorageTelemetry

Don't log session storage errors
microsoft · Nov 4, 2016 · 92c2e6c · 92c2e6c
2 parents d396080 + bcebcaa
commit 92c2e6c
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/JavaScript/JavaScriptSDK/Util.ts b/JavaScript/JavaScriptSDK/Util.ts
@@ -87,6 +87,8 @@ module Microsoft.ApplicationInsights {
                 try {
                     return storage.getItem(name);
                 } catch (e) {
+                    Util._canUseLocalStorage = false;
+
                     var message = new _InternalLogMessage(
                         _InternalMessageId.NONUSRACT_BrowserCannotReadLocalStorage,
                         "Browser failed read of local storage. " + Util.getExceptionName(e),
@@ -112,6 +114,8 @@ module Microsoft.ApplicationInsights {
                     storage.setItem(name, data);
                     return true;
                 } catch (e) {
+                    Util._canUseLocalStorage = false;
+
                     var message = new _InternalLogMessage(
                         _InternalMessageId.NONUSRACT_BrowserCannotWriteLocalStorage,
                         "Browser failed write to local storage. " + Util.getExceptionName(e),
@@ -136,6 +140,8 @@ module Microsoft.ApplicationInsights {
                     storage.removeItem(name);
                     return true;
                 } catch (e) {
+                    Util._canUseLocalStorage = false;
+
                     var message = new _InternalLogMessage(
                         _InternalMessageId.NONUSRACT_BrowserFailedRemovalFromLocalStorage,
                         "Browser failed removal of local storage item. " + Util.getExceptionName(e),
@@ -200,12 +206,14 @@ module Microsoft.ApplicationInsights {
                 try {
                     return storage.getItem(name);
                 } catch (e) {
+                    Util._canUseSessionStorage = false;
+
                     var message = new _InternalLogMessage(
                         _InternalMessageId.NONUSRACT_BrowserCannotReadSessionStorage,
                         "Browser failed read of session storage. " + Util.getExceptionName(e),
                         { exception: Util.dump(e) }
                     );
-                    _InternalLogging.throwInternalNonUserActionable(LoggingSeverity.CRITICAL, message);
+                    _InternalLogging.throwInternalNonUserActionable(LoggingSeverity.WARNING, message);
                 }
             }
             return null;
@@ -225,12 +233,14 @@ module Microsoft.ApplicationInsights {
                     storage.setItem(name, data);
                     return true;
                 } catch (e) {
+                    Util._canUseSessionStorage = false;
+
                     var message = new _InternalLogMessage(
                         _InternalMessageId.NONUSRACT_BrowserCannotWriteSessionStorage,
                         "Browser failed write to session storage. " + Util.getExceptionName(e),
                         { exception: Util.dump(e) }
                     );
-                    _InternalLogging.throwInternalNonUserActionable(LoggingSeverity.CRITICAL, message);
+                    _InternalLogging.throwInternalNonUserActionable(LoggingSeverity.WARNING, message);
                 }
             }
             return false;
@@ -249,12 +259,14 @@ module Microsoft.ApplicationInsights {
                     storage.removeItem(name);
                     return true;
                 } catch (e) {
+                    Util._canUseSessionStorage = false;
+
                     var message = new _InternalLogMessage(
                         _InternalMessageId.NONUSRACT_BrowserFailedRemovalFromSessionStorage,
                         "Browser failed removal of session storage item. " + Util.getExceptionName(e),
                         { exception: Util.dump(e) }
                     );
-                    _InternalLogging.throwInternalNonUserActionable(LoggingSeverity.CRITICAL, message);
+                    _InternalLogging.throwInternalNonUserActionable(LoggingSeverity.WARNING, message);
                 }
             }
             return false;