add error stack check (#1900)

microsoft · Sep 12, 2022 · ac1d628 · ac1d628
1 parent f9f92f6
commit ac1d628
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/shared/AppInsightsCommon/Tests/Unit/src/Exception.tests.ts b/shared/AppInsightsCommon/Tests/Unit/src/Exception.tests.ts
@@ -84,5 +84,30 @@ export class ExceptionTests extends AITestClass {
                 // Assert.deepEqual(stackFrame, stackFrameConverted);
             }
         });
+
+        this.testCase({
+            name: "StackFrame: ErrorStack can be exported from reason object of errorObj",
+            test: () => {
+                let errObj = {
+                    reason:{
+                        message: "message",
+                        stack: "TypeError: undefined\n at Function.assign(<file>)"
+                    }
+                };
+                let errDetail = {
+                    src: "TypeError: undefined\n at Function.assign(<file>)",
+                    obj:["TypeError: undefined"," at Function.assign(<file>)"]
+                };
+                let exception = Exception.CreateAutoException("message",
+                    "url",
+                    9,
+                    0,
+                    errObj
+                );
+
+                Assert.ok(exception.stackDetails);
+                Assert.deepEqual(exception.stackDetails, errDetail);
+            }
+        });
     }
 }
diff --git a/shared/AppInsightsCommon/src/Telemetry/Exception.ts b/shared/AppInsightsCommon/src/Telemetry/Exception.ts
@@ -158,6 +158,9 @@ function _getStackFromErrorObj(errorObj:any): IStackDetails {
             } else if (window && window["opera"] && errorObj[strMessage]) {
                 // Opera
                 details = _getOperaStack(errorObj.message);
+            } else if (errorObj["reason"] && errorObj.reason[strStack]) {
+                // UnhandledPromiseRejection
+                details = _convertStackObj(errorObj.reason[strStack]);
             } else if (isString(errorObj)) {
                 details = _convertStackObj(errorObj);
             } else {