[BUG] Snippet initialization with IE8/9 fails with minified code (wor…

…ks with un-minified code) #1852
microsoft · Jun 14, 2022 · ae2e478 · ae2e478
1 parent 796caa3
commit ae2e478
Show file tree

Hide file tree

Showing 24 changed files with 551 additions and 393 deletions.
diff --git a/AISKU/rollup.config.js b/AISKU/rollup.config.js
@@ -74,12 +74,15 @@ const browserRollupConfigFactory = (isProduction, libVersion = '2', format = 'um
     browserRollupConfig.plugins.push(
       uglify({
         ie8: true,
+        ie: true,
         toplevel: true,
         compress: {
+          ie: true,
           passes:3,
           unsafe: true
         },
         output: {
+          ie: true,
           preamble: banner,
           webkit:true
         }
@@ -128,12 +131,15 @@ const nodeUmdRollupConfigFactory = (isProduction) => {
     nodeRollupConfig.plugins.push(
       uglify({
         ie8: true,
+        ie: true,
         toplevel: true,
         compress: {
+          ie: true,
           passes:3,
           unsafe: true
         },
         output: {
+          ie: true,
           preamble: banner,
           webkit:true
         }

diff --git a/AISKU/src/ApplicationInsightsContainer.ts b/AISKU/src/ApplicationInsightsContainer.ts
@@ -6,7 +6,7 @@ export class ApplicationInsightsContainer {
 
     public static getAppInsights(snippet: Snippet, version: number) : IApplicationInsights | IAppInsightsDeprecated {
         const initialization = new ApplicationInsights(snippet);
-        const legacyMode = version !== 2.0 ? true : false;
+        const legacyMode = version >= 2 ? false: true;
 
         // Side effect is to create, initialize and listen to the CoreUtils._canUseCookies changes
         // Called here to support backward compatibility
@@ -17,7 +17,7 @@ export class ApplicationInsightsContainer {
         // 2. Customer updates to new snippet (that uses cdn location to new SDK. This is same as a new customer onboarding
         // and all api signatures are expected to map to new SDK. Note new snippet specifies version
 
-        if (version === 2.0) {
+        if (!legacyMode) {
             initialization.updateSnippetDefinitions(snippet);
             initialization.loadAppInsights(legacyMode);
             return initialization; // default behavior with new snippet

diff --git a/AISKU/src/Init.ts b/AISKU/src/Init.ts
@@ -33,7 +33,7 @@ try {
 
                 // overwrite snippet with full appInsights
                 // only initiaize if required and detected snippet version is >= 2 or not defined
-                if ((snippet.version >= 2.0 && (_window[aiName] as any).initialize) || snippet.version === undefined ) {
+                if ((snippet.version >= 2 && (_window[aiName] as any).initialize) || snippet.version === undefined ) {
                     ApplicationInsightsContainer.getAppInsights(snippet, snippet.version);
                 }
             }

diff --git a/AISKULight/rollup.config.js b/AISKULight/rollup.config.js
@@ -66,12 +66,15 @@ const browserRollupConfigFactory = (isProduction, libV = '2') => {
     browserRollupConfig.plugins.push(
       uglify({
         ie8: true,
+        ie: true,
         toplevel: true,
         compress: {
+          ie: true,
           passes:3,
           unsafe: true
         },
         output: {
+          ie: true,
           preamble: banner,
           webkit:true
         }
@@ -114,12 +117,15 @@ const nodeUmdRollupConfigFactory = (isProduction) => {
     nodeRollupConfig.plugins.push(
       uglify({
         ie8: true,
+        ie: true,
         toplevel: true,
         compress: {
+          ie: true,
           passes:3,
           unsafe: true
         },
         output: {
+          ie: true,
           preamble: banner,
           webkit:true
         }

diff --git a/channels/applicationinsights-channel-js/rollup.config.js b/channels/applicationinsights-channel-js/rollup.config.js
@@ -65,12 +65,15 @@ const browserRollupConfigFactory = isProduction => {
     browserRollupConfig.plugins.push(
       uglify({
         ie8: true,
+        ie: true,
         toplevel: true,
         compress: {
+          ie: true,
           passes:3,
           unsafe: true
         },
         output: {
+          ie: true,
           preamble: banner,
           webkit:true
         }
@@ -113,12 +116,15 @@ const nodeUmdRollupConfigFactory = (isProduction) => {
     nodeRollupConfig.plugins.push(
       uglify({
         ie8: true,
+        ie: true,
         toplevel: true,
         compress: {
+          ie: true,
           passes:3,
           unsafe: true
         },
         output: {
+          ie: true,
           preamble: banner,
           webkit:true
         }