add one more restriction on the length of exception #1990 (#2006)

microsoft · Mar 6, 2023 · ed8b351 · ed8b351
2 parents 044384b + 0363f2b
commit ed8b351
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 1 deletion.
diff --git a/shared/AppInsightsCommon/Tests/Unit/src/Exception.tests.ts b/shared/AppInsightsCommon/Tests/Unit/src/Exception.tests.ts
@@ -1,5 +1,5 @@
 import { Assert, AITestClass } from "@microsoft/ai-test-framework";
-import { Exception } from "../../../src/applicationinsights-common"
+import { DataSanitizer, Exception } from "../../../src/applicationinsights-common"
 import { DiagnosticLogger } from "@microsoft/applicationinsights-core-js";
 import { IExceptionInternal, IExceptionDetailsInternal, IExceptionStackFrameInternal } from "../../../src/Interfaces/IExceptionTelemetry";
 import { _ExceptionDetails, _StackFrame } from "../../../src/Telemetry/Exception";
@@ -61,6 +61,44 @@ export class ExceptionTests extends AITestClass {
             }
         });
 
+        this.testCase({
+            name: "ExceptionDetails: ExceptionDetails assembly field will be truncated",
+            test: () => {
+                try {
+                    // const define
+                    const MAX_STRING_LENGTH = DataSanitizer.MAX_STRING_LENGTH;
+                    const messageLong = new Array(MAX_STRING_LENGTH + 10).join("abc");
+
+                    const messageFollowRegex = "at functionName (a.js:1:1)"
+                    const longMessageFollowRegex = messageFollowRegex.replace("functionName", messageLong)
+
+                    let errObj = {
+                        reason:{
+                            message: "message",
+                            stack: longMessageFollowRegex + "\n" + longMessageFollowRegex + "\n" + longMessageFollowRegex
+                        }
+                    };
+
+                    let exception = Exception.CreateAutoException("message",
+                        "url",
+                        9,
+                        0,
+                        errObj
+                    );
+                    const exceptionDetails = new _ExceptionDetails(this.logger, exception);
+
+                    for (let i = 0; i < exceptionDetails.parsedStack.length; i++) {
+                        Assert.ok(exceptionDetails.parsedStack[i].assembly.length <= MAX_STRING_LENGTH);
+                      }
+                } catch (e) {
+                    console.log(e.stack);
+                    console.log(e.toString());
+                    Assert.ok(false, e.toString());
+                }
+            }
+        });
+
+
         this.testCase({
             name: "StackFrame: StackFrame can be exported to interface format",
             test: () => {

diff --git a/shared/AppInsightsCommon/src/Telemetry/Exception.ts b/shared/AppInsightsCommon/src/Telemetry/Exception.ts
@@ -533,6 +533,12 @@ export class _ExceptionDetails implements IExceptionDetails, ISerializable {
             _self.message = dataSanitizeMessage(logger, _formatMessage(exception || error, _self.typeName)) || strNotSpecified;
             const stack = exception[strStackDetails] || _getStackFromErrorObj(exception);
             _self.parsedStack = _parseStack(stack);
+
+            // after parsedStack is inited, iterate over each frame object, sanitize its assembly field
+            if (isArray(_self.parsedStack)){
+                arrMap(_self.parsedStack, (frame: _StackFrame) => frame.assembly = dataSanitizeString(logger, frame.assembly));
+            }
+
             _self[strStack] = dataSanitizeException(logger, _formatStackTrace(stack));
             _self.hasFullStack = isArray(_self.parsedStack) && _self.parsedStack.length > 0;