Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] When a fetch polyfill is installed the reporting endpoint is also causing events to be sent #1204

Closed
MSNev opened this issue Mar 3, 2020 · 3 comments
Closed

[BUG] When a fetch polyfill is installed the reporting endpoint is also causing events to be sent #1204

MSNev opened this issue Mar 3, 2020 · 3 comments
Assignees
@MSNev
Labels
bug

Comments

@MSNev
Copy link
Collaborator

MSNev commented Mar 3, 2020

Steps to Reproduce
Run in an environment that does not support fetch (eg, Phantom JS, React Native) and install a fetch polyfill (eg. whatwg-fetch).

Now whenever a fetch request is called from within the SDK that request is also instrumented (this is an extension and not part of the default configuration)

Expected behavior
The internal reporting requests should not cause additional requests to be sent.
@MSNev MSNev self-assigned this Mar 3, 2020
@MSNev MSNev added the bug label Mar 3, 2020
MSNev pushed a commit that referenced this issue Mar 3, 2020
[BUG] When a fetch polyfill is installed there reporting endpoint is …
921c9fa 
…also causing events to be sent #1204
MSNev pushed a commit that referenced this issue Mar 4, 2020
[BUG] When a fetch polyfill is installed there reporting endpoint is …
b73b297 
…also causing events to be sent #1204
@MSNev MSNev changed the title [BUG] When a fetch polyfill is installed there reporting endpoint is also causing events to be sent [BUG] When a fetch polyfill is installed the reporting endpoint is also causing events to be sent Mar 4, 2020
MSNev added a commit that referenced this issue Mar 4, 2020
@MSNev
[BUG] When a fetch polyfill is installed there reporting endpoint is …
be5860d 
…also causing events to be sent #1204 (#1205)
@MSNev
Copy link
Collaborator Author

MSNev commented Mar 6, 2020

We published version 2.5.1 to npm last night, which should address this issue. Once we complete the rollout to the CDN, I'll close this issue.

@MSNev
Copy link
Collaborator Author

MSNev commented Mar 11, 2020

Version 2.5.2 is now fully deployed to the CDN, closing as this should address this issue.

@MSNev MSNev closed this as completed Mar 11, 2020
@snyk-bot snyk-bot mentioned this issue Apr 4, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Apr 17, 2020
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MSNev