Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Performance / Testing support #1335

Closed
MSNev opened this issue Aug 3, 2020 · 2 comments
Closed

Add Performance / Testing support #1335

MSNev opened this issue Aug 3, 2020 · 2 comments
Assignees
@MSNev
Labels
enhancement
Milestone
2.5.7

Comments

@MSNev
Copy link
Collaborator

MSNev commented Aug 3, 2020

As part of the changes for #1076, this hides the previously exposed "private" properties and methods on the JavaScript object. So while TypeScript complains we have several customers that consume library directly via JavaScript and they would directly hook / mock these methods for testing / monitoring.

To unblock these users we need to provide a standard method to allow hooking of these methods even for minified code, as the minification process renames these internal non-exposed values (by design to support minifaction)
@MSNev MSNev self-assigned this Aug 3, 2020
@MSNev MSNev added this to the 2.5.7 milestone Aug 3, 2020
MSNev pushed a commit that referenced this issue Aug 5, 2020
Add Performance / Testing support #1335
4719d1e 
[BUG] DebugPlugin various updates #1333
MSNev pushed a commit that referenced this issue Aug 5, 2020
Add Performance / Testing support #1335
553a3a1 
[BUG] DebugPlugin various updates #1333
MSNev pushed a commit that referenced this issue Aug 5, 2020
Add Performance / Testing support #1335
b80a58d 
[BUG] DebugPlugin various updates #1333
MSNev pushed a commit that referenced this issue Aug 5, 2020
Add Performance / Testing support #1335
7390d84 
[BUG] DebugPlugin various updates #1333
MSNev added a commit that referenced this issue Aug 6, 2020
@MSNev
Add Performance / Testing support #1335 and [BUG] DebugPlugin various…
a4bc234 
… updates #1333 (#1337)

* Add Performance / Testing support #1335
[BUG] DebugPlugin various updates #1333

Addressing PR comments
* Address comments and delay the execution of the payloadDetails callback until needed
* Update the documented default value
@MSNev MSNev added fixed - waiting release PR Committed and waiting deployment and removed fixed - waiting release PR Committed and waiting deployment labels Aug 6, 2020
@MSNev
Copy link
Collaborator Author

MSNev commented Aug 11, 2020

Fully Deployed to CDN and NPM as version 2.5.7

@MSNev MSNev closed this as completed Aug 11, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
enhancement
Projects
None yet
Milestone
2.5.7
Development

No branches or pull requests
1 participant
@MSNev