Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] IPerfManager interface - the create() function is defined to return an IPerfEvent and not an IPerfEvent? #1343

Closed
MSNev opened this issue Aug 13, 2020 · 2 comments
Closed

[BUG] IPerfManager interface - the create() function is defined to return an IPerfEvent and not an IPerfEvent? #1343

MSNev opened this issue Aug 13, 2020 · 2 comments
Assignees
@MSNev
Labels
bug
Milestone
2.5.8

Comments

@MSNev
Copy link
Collaborator

MSNev commented Aug 13, 2020

there's a minor typescript problem with the IPerfManager interface - the create() function is defined to return an IPerfEvent and not an IPerfEvent?, so it can't return null/undefined (temporarily worked around by returning null as any as IPerfEvent)
@MSNev MSNev added the bug label Aug 13, 2020
@MSNev MSNev self-assigned this Aug 13, 2020
MSNev pushed a commit that referenced this issue Aug 13, 2020
[BUG] IPerfManager interface - the create() function is defined to re…
a5a56ec 
…turn an IPerfEvent and not an IPerfEvent? #1343
MSNev pushed a commit that referenced this issue Aug 13, 2020
[BUG] IPerfManager interface - the create() function is defined to re…
bc3c467 
…turn an IPerfEvent and not an IPerfEvent? #1343
MSNev added a commit that referenced this issue Aug 14, 2020
@MSNev
[BUG] IPerfManager interface - the create() function is defined to re…
ebf624c 
…turn an IPerfEvent and not an IPerfEvent? #1343 (#1344)
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Aug 26, 2020
@MSNev MSNev added this to the 2.5.8 milestone Aug 27, 2020
@MSNev
Copy link
Collaborator Author

MSNev commented Sep 1, 2020

v2.5.8 is now fully deployed

@MSNev MSNev closed this as completed Sep 1, 2020
@MSNev MSNev removed the fixed - waiting release PR Committed and waiting deployment label Sep 30, 2020
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
bug
Projects
None yet
Milestone
2.5.8
Development

No branches or pull requests
1 participant
@MSNev