Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] The new IPerfEvent is using Date.now() which is not supported in an ES3 environment #1350

Closed
MSNev opened this issue Aug 26, 2020 · 2 comments
Closed

[BUG] The new IPerfEvent is using Date.now() which is not supported in an ES3 environment #1350

MSNev opened this issue Aug 26, 2020 · 2 comments
Assignees
@MSNev
Labels
bug es3 ES3 Issues (IE8)
Milestone
2.5.8

Comments

@MSNev
Copy link
Collaborator

MSNev commented Aug 26, 2020

Date.now() is only supported from IE9 -> so we need to provide a polyfill helper
additionally, performance.now() is also only available from IE 10-> so this also needs a polyfill helper.

Will

  • add helper functions
  • add additional checks in the es3 checking tool
@MSNev MSNev added bug es3 ES3 Issues (IE8) labels Aug 26, 2020
@MSNev MSNev self-assigned this Aug 26, 2020
MSNev pushed a commit that referenced this issue Aug 26, 2020
[BUG] The new IPerfEvent is using Date.now() which is not supported i…
a2cb522 
…n an ES3 environment #1350
MSNev pushed a commit that referenced this issue Aug 27, 2020
[BUG] The new IPerfEvent is using Date.now() which is not supported i…
632d8e8 
…n an ES3 environment #1350
MSNev added a commit that referenced this issue Aug 27, 2020
@MSNev
[BUG] The new IPerfEvent is using Date.now() which is not supported i…
190ddeb 
…n an ES3 environment #1350 (#1351)
@MSNev MSNev added this to the 2.5.8 milestone Aug 27, 2020
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Aug 27, 2020
@MSNev
Copy link
Collaborator Author

MSNev commented Sep 1, 2020

v2.5.8 is now fully deployed

@MSNev MSNev closed this as completed Sep 1, 2020
@MSNev MSNev removed the fixed - waiting release PR Committed and waiting deployment label Sep 30, 2020
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
bug es3 ES3 Issues (IE8)
Projects
None yet
Milestone
2.5.8
Development

No branches or pull requests
1 participant
@MSNev