Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] New dts gneration doesn't work when the environment doesn't have powershell #1473

Closed
MSNev opened this issue Feb 10, 2021 · 4 comments
Closed

[BUG] New dts gneration doesn't work when the environment doesn't have powershell #1473

MSNev opened this issue Feb 10, 2021 · 4 comments
Assignees
@MSNev
Labels
build-issue This is a build or build environment issue p1 released - NPM
Milestone
2.6.0

Comments

@MSNev
Copy link
Collaborator

MSNev commented Feb 10, 2021

The dtsgen.ps1 script called from the default build task fails in environments when powershell is not available.

  • github build environment checks run on linux.

The script should be converted from powershell to JS so it can natively run.
@MSNev MSNev self-assigned this Feb 10, 2021
@MSNev MSNev added build-issue This is a build or build environment issue p3 p1 and removed p3 labels Feb 10, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Feb 13, 2021

Upgrading to a p1 as this is causing the github build to fail silently as it's built on a ubuntu instance.

MSNev added a commit that referenced this issue Feb 17, 2021
@MSNev
[BUG] New dts gneration doesn't work when the environment doesn't hav…
8e506a7 
…e powershell #1473

- Convert PowerShell script to a nodejs one.
MSNev added a commit that referenced this issue Feb 17, 2021
@MSNev
[BUG] New dts gneration doesn't work when the environment doesn't hav…
8eba542 
…e powershell #1473 (#1475)

- Convert PowerShell script to a nodejs one.
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Feb 17, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Feb 17, 2021

Adding "fixed - waiting release" for tracking, but as this is a build issue it is technically already fixed and active.

@MSNev MSNev added this to the 2.6.0 milestone Feb 19, 2021
@MSNev MSNev mentioned this issue Mar 10, 2021
Closed
@MSNev MSNev added released - NPM and removed fixed - waiting release PR Committed and waiting deployment labels Mar 24, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Mar 29, 2021

v2.6.0 is now fully deployed to all CDN endpoints

@MSNev MSNev closed this as completed Mar 29, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
build-issue This is a build or build environment issue p1 released - NPM
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
1 participant
@MSNev