Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Investigate changing the sideEffects: false to list only the files that include the shims module from the all AI modules so that webpack can evaluate correctly #1509

Closed
MSNev opened this issue Mar 24, 2021 · 3 comments
Closed

[BUG] Investigate changing the sideEffects: false to list only the files that include the shims module from the all AI modules so that webpack can evaluate correctly #1509

MSNev opened this issue Mar 24, 2021 · 3 comments
Assignees
@MSNev
Labels
released - NPM
Milestone
2.6.2

Comments

@MSNev
Copy link
Collaborator

MSNev commented Mar 24, 2021

Do NOT remove from the shims module as this is require, because it has sideEffects.
@MSNev MSNev added the bug label Mar 24, 2021
@MSNev MSNev self-assigned this Mar 24, 2021
@MSNev MSNev changed the title [BUG] Remove sideEffects: false from the all AI modules so that webpack can evaluate correctly [BUG] Investigate changing the sideEffects: false to list only the files that include the shims module from the all AI modules so that webpack can evaluate correctly Mar 24, 2021
@MSNev MSNev added investigating Investigating the issue and removed bug labels Mar 24, 2021
MSNev added a commit that referenced this issue Apr 2, 2021
@MSNev
[BUG] Investigate changing the sideEffects: false to list only the fi…
ae99036 
…les that include the shims module from the all AI modules so that webpack can evaluate correctly #1509

Investigate removing the globals __extends() and __assign() populated by applicationinsights-shims #1280
@MSNev MSNev mentioned this issue Apr 2, 2021
Merged
MSNev added a commit that referenced this issue Apr 2, 2021
@MSNev
[BUG] Investigate changing the sideEffects: false to list only the fi…
1ad1cf4 
…les that include the shims module from the all AI modules so that webpack can evaluate correctly #1509

Investigate removing the globals __extends() and __assign() populated by applicationinsights-shims #1280
MSNev added a commit that referenced this issue Apr 3, 2021
@MSNev
[BUG] Investigate changing the sideEffects: false to list only the fi…
f18eb30 
…les that include the shims module from the all AI modules so that webpack can evaluate correctly #1509

Investigate removing the globals __extends() and __assign() populated by applicationinsights-shims #1280
MSNev added a commit that referenced this issue Apr 3, 2021
@MSNev
[BUG] Investigate changing the sideEffects: false to list only the fi…
15423ca 
…les that include the shims module from the all AI modules so that webpack can evaluate correctly #1509

Investigate removing the globals __extends() and __assign() populated by applicationinsights-shims #1280
MSNev added a commit that referenced this issue Apr 14, 2021
@MSNev
[BUG] Investigate changing the sideEffects: false to list only the fi…
b5c2503 
…les that include the shims module from the all AI modules so that webpack can evaluate correctly #1509

Investigate removing the globals __extends() and __assign() populated by applicationinsights-shims #1280
MSNev added a commit that referenced this issue Apr 15, 2021
@MSNev
[BUG] Investigate changing the sideEffects: false to list only the fi…
4efdab4 
…les that include the shims module from the all AI modules so that webpack can evaluate correctly #1509

Investigate removing the globals __extends() and __assign() populated by applicationinsights-shims #1280
@MSNev MSNev removed the investigating Investigating the issue label Apr 15, 2021
@MSNev MSNev added this to the 2.x.x (Next Release) milestone Apr 15, 2021
MSNev added a commit that referenced this issue Apr 15, 2021
@MSNev
[BUG] Investigate changing the sideEffects: false to list only the fi…
1c39bf9 
…les that include the shims module from the all AI modules so that webpack can evaluate correctly #1509 (#1523)

Investigate removing the globals __extends() and __assign() populated by applicationinsights-shims #1280
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Apr 21, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 21, 2021

This is effectively fixed by upgrading to v2.0.0 of the new shims module.

@MSNev
Copy link
Collaborator Author

MSNev commented Apr 27, 2021

v2.6.2 is now fully deployed

@MSNev MSNev closed this as completed Apr 27, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
released - NPM
Projects
None yet
Milestone
2.6.2
Development

No branches or pull requests
1 participant
@MSNev