Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Config items are not functional for current snippet disableFlushOnBeforeUnload, disableFlushOnBeforeUnload and maybe others #1524

Closed
MSNev opened this issue Apr 5, 2021 · 2 comments
Closed

[BUG] Config items are not functional for current snippet disableFlushOnBeforeUnload, disableFlushOnBeforeUnload and maybe others #1524

MSNev opened this issue Apr 5, 2021 · 2 comments
Assignees
@xiao-lix
Labels
bug released - NPM
Milestone
2.6.2

Comments

@MSNev
Copy link
Collaborator

MSNev commented Apr 5, 2021

See history in #1516

When using

  • a current snippet it initializes the extension/ai-analytics-js/ApplicationInsights instance as appInsightsInstance.appInsights which is NOT initializing the disable* config items... (This is part of the bug).
  • But when using the legacy snippet this initializes the ApplicationInsightsDeprecated instance as appInsightsInstance.appInsights which initializes the disable* config items and the extension/ai-analytics-js/ApplicationInsights instance is linked as appInsightsInstance.appInsightsNew as this is where most of the work is done.

This looks like it's been broken like this for a while (so not going to elevate this to a P1), but linking to #1517 as there is a bunch of code that needs fixing here to restore compatibility.
@MSNev MSNev self-assigned this Apr 5, 2021
@MSNev MSNev added the bug label Apr 5, 2021
@MSNev MSNev mentioned this issue Apr 5, 2021
Closed
@xiao-lix xiao-lix mentioned this issue Apr 14, 2021
Merged
@MSNev MSNev assigned xiao-lix and unassigned MSNev Apr 14, 2021
@MSNev MSNev added this to the 2.x.x (Next Release) milestone Apr 15, 2021
@MSNev MSNev mentioned this issue Apr 15, 2021
Closed
xiao-lix added a commit that referenced this issue Apr 16, 2021
@xiao-lix
[BUG] address issues #1517 add unload listener and #1524 config from …
ababc00 
…snippet (#1532)

* bug fix - add unload listener and initialize missing config items

* remove unnecessary initializations and pass in config to getDefault method

* add correlationHeaderExcludePatterns default value

* fix test
@xiao-lix xiao-lix added the fixed - waiting release PR Committed and waiting deployment label Apr 16, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 27, 2021

v2.6.2 is now fully deployed

@MSNev MSNev closed this as completed Apr 27, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xiao-lix xiao-lix

Labels
bug released - NPM
Projects
None yet
Milestone
2.6.2
Development

No branches or pull requests
2 participants
@xiao-lix @MSNev