Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] React 3.1.1 does is not reusing the shims v2 module correctly -- causing __extends errors #1553

Closed
MSNev opened this issue Apr 26, 2021 · 12 comments · Fixed by #1555
Closed

[BUG] React 3.1.1 does is not reusing the shims v2 module correctly -- causing __extends errors #1553

MSNev opened this issue Apr 26, 2021 · 12 comments · Fixed by #1555
Assignees
@MSNev
Labels
bug p1 released - NPM
Milestone
React 3.1.2

Comments

@MSNev
Copy link
Collaborator

MSNev commented Apr 26, 2021

Description/Screenshot

Steps to Reproduce

  • OS/Browser:
  • SDK Version [e.g. 22]:
  • How you initialized the SDK:

Expected behavior

Additional context
Add any other context about the problem here.
@MSNev MSNev self-assigned this Apr 26, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 26, 2021

I've deprecated v3.1.1 package until I can publish an updated version

This was referenced Apr 26, 2021
Closed
Closed
Closed
Closed
Closed
@MSNev MSNev added this to the React 3.1.2 milestone Apr 27, 2021
MSNev added a commit that referenced this issue Apr 27, 2021
@MSNev
[Release][React] Increase React Plugin to version 3.1.2
6ca8f4d 
[BUG] React 3.1.1 does is not reusing the shims v2 module correctly -- causing __extends errors #1553
- Remove unnecessary shims import, fix packaging and tests
MSNev added a commit that referenced this issue Apr 27, 2021
@MSNev
[Release][React] Increase React Plugin to version 3.1.2
2714d5c 
[BUG] React 3.1.1 does is not reusing the shims v2 module correctly -- causing __extends errors #1553
- Remove unnecessary shims import, fix packaging and tests
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 27, 2021

PR to fix this is #1555

@MSNev MSNev linked a pull request Apr 27, 2021 that will close this issue
[Release][React] Increase React Plugin to version 3.1.2 #1555
Merged
MSNev added a commit that referenced this issue Apr 27, 2021
@MSNev
[Release][React] Increase React Plugin to version 3.1.2 (#1555)
8c84cf4 
[BUG] React 3.1.1 does is not reusing the shims v2 module correctly -- causing __extends errors #1553
- Remove unnecessary shims import, fix packaging and tests
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 27, 2021

Reopening for tracking

@MSNev MSNev reopened this Apr 27, 2021
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Apr 27, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 27, 2021

FYI - Internal prod build servers are timing out -- I need a good clean run to be able to release, will release as soon as I get a good run.

@MSNev
Copy link
Collaborator Author

MSNev commented Apr 28, 2021

Still having issues with the new tests on the internal servers -- still working on it

@MSNev
Copy link
Collaborator Author

MSNev commented Apr 28, 2021

Finally got a good build, however, the publish step is broken and will require an update -- unlike to get this fixed today now 😞 😭

@MSNev MSNev removed the fixed - waiting release PR Committed and waiting deployment label Apr 28, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 28, 2021

Publish step is broken

@sujitykulkarni
Copy link

Got socket timeout issue with fresh npm install attempt just now (28th APr 2021 21:20 IST).

npm ERR! request to https://registry.npmjs.org/@microsoft/applicationinsights-shims/-/applicationinsights-shims-2.0.0.tgz failed, reason: Socket timeout
Is it due to broken publish?

@MSNev
Copy link
Collaborator Author

MSNev commented Apr 28, 2021

@sujitykulkarni, no that is not due to the broken publish, that sounds like a network issue or a problem on the npmjs servers.

The publish issue is an issue in the way the production build servers prepare the tarball, and turns out that even though we have a pre-package step the publish was re-creating it without have full access to all of the packages (on the publish servers) the fix for this is in PR #1557

@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Apr 28, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 28, 2021

PR is merged, back on the waiting for official internal build generation before publishing -- hopefully this will complete within the next few hours (yes can take this long 😢 )

@MSNev MSNev added released - NPM and removed fixed - waiting release PR Committed and waiting deployment labels Apr 28, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 28, 2021

Ok, finally published!!!

If there are still issues related to this please comment here and I'll jump on it.
For now closing this issue.

@MSNev MSNev closed this as completed Apr 28, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
bug p1 released - NPM
Projects
None yet
Milestone
React 3.1.2
Development

Successfully merging a pull request may close this issue.

[Release][React] Increase React Plugin to version 3.1.2 microsoft/ApplicationInsights-JS
2 participants
@sujitykulkarni @MSNev