Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] URL without host fails in CanIncludeCorrelationHeader #1580

Closed
panda7789 opened this issue Jun 15, 2021 · 3 comments
Closed

[BUG] URL without host fails in CanIncludeCorrelationHeader #1580

panda7789 opened this issue Jun 15, 2021 · 3 comments
Assignees
Milestone

Comments

@panda7789
Copy link

Description

When fetching url without host like this:
"../../api/v01/as/descriptions/Attributes?className=Polozky_smlouvy"
in method canIncludeCorrelationHeader it fails on parsing host, because url doesnt have host (missing www.host.com on begin).

image
image

Steps to Reproduce

  • OS/Browser: Edge
  • SDK Version [e.g. 22]: @microsoft/applicationinsights-web: 2.6.2
  • How you initialized the SDK:
new ApplicationInsights({
       config: {
           instrumentationKey: iKey,
           disableCorrelationHeaders: false,
           disableFetchTracking: false,
           disableAjaxTracking: false,
           enableRequestHeaderTracking: true,
           maxAjaxCallsPerView: 200,
           correlationHeaderDomains: ["app2.loc", "app1.loc", "portal.loc/api/"]
       }

Expected behavior

It shouldn't fail, local api calls should be ok.

@MSNev
Copy link
Collaborator

MSNev commented Jun 16, 2021

Agree it should not fail / throw

@MSNev
Copy link
Collaborator

MSNev commented Jul 12, 2021

Now fully deployed to all CDN endpoints

@MSNev MSNev closed this as completed Jul 12, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants