URL without host should not fails canIncludeCorrelationHeader right away #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiao-lix
commented
Jun 17, 2021
| @@ -65,7 +65,7 @@ export function urlGetCompleteUrl(method: string, absoluteUrl: string) { | |||
|
|
|||
| // Fallback method to grab host from url if document.createElement method is not available | |||
| export function urlParseHost(url: string, inclPort?: boolean) { | |||
| let fullHost = urlParseFullHost(url, inclPort); | |||
| let fullHost = urlParseFullHost(url, inclPort) || ""; | |||
There was a problem hiding this comment.
Add | "" means when url has no host, the urlParseFullHost method returns null. In that case, null passed back to here but null.toLowerCase() is wrong. So always return an empty string when host is not detected.
xiao-lix
commented
Jun 17, 2021
| @@ -238,9 +238,9 @@ export interface IUtil { | |||
|
|
|||
| export const Util: IUtil = { | |||
| NotSpecified: strNotSpecified, | |||
| createDomEvent: createDomEvent, | |||
| createDomEvent, | |||
There was a problem hiding this comment.
Fix some ts-lint errors
xiao-lix
commented
Jun 17, 2021
| @@ -355,7 +355,7 @@ export const CorrelationIdHelper: ICorrelationIdHelper = { | |||
| requestHost = (urlParseFullHost(requestUrl, true) || "").toLowerCase(); | |||
| } | |||
|
|
|||
| if ((!config || !config.enableCorsCorrelation) && requestHost !== currentHost) { | |||
| if ((!config || !config.enableCorsCorrelation) && (requestHost && requestHost !== currentHost)) { | |||
There was a problem hiding this comment.
ONLY check if the requestHost equals currentHost when requestHost exists. For the case that requestHost not exist (empty string when host not exist) skip the check. Otherwise it will returns false right away for the cases that url without host.
kryalama
approved these changes
Jun 17, 2021
MSNev
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1580