Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] empty messages for unhandled promise rejections #1608

Closed
JohnnyFun opened this issue Jul 13, 2021 · 8 comments
Closed

[BUG] empty messages for unhandled promise rejections #1608

JohnnyFun opened this issue Jul 13, 2021 · 8 comments
Assignees
Milestone

Comments

@JohnnyFun
Copy link

JohnnyFun commented Jul 13, 2021

Description/Screenshot
message is passed as theEvent from Exception.CreateAutoException. Should evt been passed instead? And/or should you fall back to theEvent if it's a string?

image

image

Results in these empty error messages, so I don't see the actual error.
image

  • SDK Version: 2.6.4
@MSNev
Copy link
Collaborator

MSNev commented Jul 13, 2021

Should evt been passed instead?

No

And/or should you fall back to theEvent if it's a string?

Yes

@MSNev MSNev added the bug label Jul 13, 2021
@MSNev MSNev self-assigned this Jul 13, 2021
@MSNev MSNev added this to the 2.x.x (Future Release) milestone Jul 13, 2021
@MSNev
Copy link
Collaborator

MSNev commented Jul 13, 2021

The fix is going to look like this

   if (evtMessage && !isString(evtMessage)) {
       evtMessage = theEvent[strMessage] || theEvent[strDescription] || evtMessage;
   }

@JohnnyFun
Copy link
Author

Sounds good, thanks for jumping on that. I'll just downgrade for now. When do you think that'll be released?

Fwiw, my stack trace also was empty. Looking at the code it looks like it would've used error.stack, so not sure why that happened. But I'll let you know if I find anything.

@MSNev
Copy link
Collaborator

MSNev commented Jul 13, 2021

At the moment it will be the next cycle so we will start this process in the first week of August

@MSNev
Copy link
Collaborator

MSNev commented Aug 9, 2021

v2.6.5 is now fully deployed

@MSNev MSNev closed this as completed Aug 9, 2021
@JohnnyFun
Copy link
Author

JohnnyFun commented Sep 20, 2021

Looks like message is coming through now, but there appears to be no stack trace.

It used to show up in this "details" section from azure insights UI:
image

The user was using chrome 92, so shouldn't be a browser issue where it just provides a terrible error.stack value or something.

Let me know if you need any other information. Worst case, I might just add that as a custom dimension for now.

And fwiw, that's a custom error that we explicitly throw from a js file: throw new Error('Should not call this with student persona.')

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2022
@MSNev
Copy link
Collaborator

MSNev commented Sep 21, 2022

#1679

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants