Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Addition of stdDev metric support has broken custom metric reporting from #1680 #1729

Closed
MSNev opened this issue Dec 6, 2021 · 2 comments
Closed

[BUG] Addition of stdDev metric support has broken custom metric reporting from #1680 #1729

MSNev opened this issue Dec 6, 2021 · 2 comments
Assignees
@MSNev
Labels
bug released - NPM
Milestone
2.7.2

Comments

@MSNev
Copy link
Collaborator

MSNev commented Dec 6, 2021 •
edited
Loading

This change is broken for the JS api. This change missed updating the constructor invocation in MetricEnvelopeCreator under EnvelopeCreator.ts and so is now passing props as the stdDev argument. All customDimensions are now lost when tracking any kind of metric.

#1680 Issue that was being addressed
#1701 Introduced issue
@MSNev MSNev added the bug label Dec 6, 2021
@MSNev MSNev added this to the 2.7.2 milestone Dec 6, 2021
MSNev added a commit to MSNev/ApplicationInsights-JS that referenced this issue Dec 6, 2021
@MSNev
[BUG] Addition of stdDev metric support has broken custom metric repo…
8941045 
…rting from microsoft#1680 microsoft#1729
@MSNev MSNev self-assigned this Dec 6, 2021
MSNev added a commit that referenced this issue Dec 7, 2021
@MSNev
[BUG] Addition of stdDev metric support has broken custom metric repo…
1789620 
…rting from #1680 #1729 (#1730)
@MSNev MSNev added fixed - waiting release PR Committed and waiting deployment released - NPM waiting - CDN deployment and removed fixed - waiting release PR Committed and waiting deployment waiting - CDN deployment labels Dec 7, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Dec 8, 2021

Now fully released

@MSNev MSNev closed this as completed Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
bug released - NPM
Projects
None yet
Milestone
2.7.2
Development

No branches or pull requests
1 participant
@MSNev