Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] SharedWorker does not Instrument fetch correctly #1996

Closed
MSNev opened this issue Feb 17, 2023 · 2 comments
Closed

[BUG] SharedWorker does not Instrument fetch correctly #1996

MSNev opened this issue Feb 17, 2023 · 2 comments
Assignees
@MSNev
Labels
p1 released - NPM service-worker Required to properly support service workers shared-worker
Milestone
2.8.11

Comments

@MSNev
Copy link
Collaborator

MSNev commented Feb 17, 2023

@celluj34 has identified as part of issue #1995 that for a Shared worker the InstrumentFunc for the fetch is not working due to checks around hasOwnProperty failing for globalThis.fetch and the beta usage of Object.getOwnPropertyDescriptor also fails.

We need to investigate and add an additional fallback from the _getOwner() or equivalent to use either an existence check and/or in. We also need to validate that even with these checks that we can correctly hook the relevant function and/or prototype.

This should be fixed in v2.x (if possible) and v3.x.
@MSNev MSNev added p1 service-worker Required to properly support service workers shared-worker labels Feb 17, 2023
@MSNev MSNev self-assigned this Feb 17, 2023
@MSNev MSNev modified the milestones: 2.8.11, 3.0.0 Feb 17, 2023
@MSNev
Copy link
Collaborator Author

MSNev commented Feb 17, 2023

Assigned to 2.8.11 so we can attempt to address in v2 which will them also get merged to v3 (beta)

MSNev added a commit to MSNev/ApplicationInsights-JS that referenced this issue Feb 23, 2023
@MSNev
[Beta] [BUG] SharedWorker does not Instrument fetch correctly microso…
c9d22d7 
…ft#1996

- Also add a Shared Worker example
MSNev added a commit that referenced this issue Feb 23, 2023
@MSNev
[Beta] [BUG] SharedWorker does not Instrument fetch correctly #1996
40cb698 
- Also add a Shared Worker example
@MSNev MSNev mentioned this issue Feb 23, 2023
Closed
MSNev added a commit to MSNev/ApplicationInsights-JS that referenced this issue Feb 23, 2023
@MSNev
[Beta] [BUG] SharedWorker does not Instrument fetch correctly microso…
73cebfe 
…ft#1996

- Also add a Shared Worker example
MSNev added a commit that referenced this issue Feb 24, 2023
@MSNev
[Beta] [BUG] SharedWorker does not Instrument fetch correctly #1996 (#…
276575b 
…2000)

- Also add a Shared Worker example
MSNev added a commit that referenced this issue Feb 24, 2023
@MSNev
[Beta] [BUG] SharedWorker does not Instrument fetch correctly #1996
2565ee3 
- Also add a Shared Worker example
@MSNev MSNev mentioned this issue Feb 24, 2023
Merged
MSNev added a commit that referenced this issue Feb 27, 2023
@MSNev
[Beta] [BUG] SharedWorker does not Instrument fetch correctly #1996
925f18b 
- Also add a Shared Worker example
MSNev added a commit that referenced this issue Feb 28, 2023
@MSNev
[Master] [BUG] SharedWorker does not Instrument fetch correctly #1996 (…
fcadeec 
…#2001)

- Merge from `beta` [BUG] SharedWorker does not Instrument fetch
correctly #1996
- [BUG] App Insights not auto-capturing from a Web Worker #1995
@MSNev MSNev added fixed - waiting release PR Committed and waiting deployment waiting - CDN deployment released - NPM and removed fixed - waiting release PR Committed and waiting deployment labels Mar 8, 2023
@MSNev MSNev closed this as completed Mar 15, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
p1 released - NPM service-worker Required to properly support service workers shared-worker
Projects
None yet
Milestone
2.8.11
Development

No branches or pull requests
1 participant
@MSNev