Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Contradiction in Readme about fetch #2005

Closed
StefanSchoof opened this issue Mar 3, 2023 · 2 comments
Closed

[BUG] Contradiction in Readme about fetch #2005

StefanSchoof opened this issue Mar 3, 2023 · 2 comments
Assignees
Milestone

Comments

@StefanSchoof
Copy link

Description/Screenshot
The readme stat at one place the fetch collection is disabled by default and on an other place that it is active by default:

Setting Up Autocollection

Network Dependency Requests made by your app XHR and Fetch (fetch collection is disabled by default) requests, include information on

Configuration

disableFetchTracking | boolean | false | If true, Fetch requests are not autocollected. Default is false (Since v2.8.0, previously true)

I assume, that "fetch collection is disabled by default" has been not updated, when changing the default in 2.8.0

Steps to Reproduce

  • OS/Browser:
  • SDK Version [e.g. 22]:
  • How you initialized the SDK:

Expected behavior

No Contradiction about fetch in the documentation.

Additional context
Add any other context about the problem here.

@MSNev MSNev assigned MSNev and siyuniu-ms and unassigned MSNev Mar 3, 2023
@MSNev
Copy link
Collaborator

MSNev commented Mar 3, 2023

Correct, we need to update the documentation to indicate that it is now enabled by default (since 2.8.0)

Thank you.

siyuniu-ms added a commit that referenced this issue Mar 8, 2023
@MSNev MSNev added this to the 2.8.11 milestone Mar 8, 2023
@MSNev MSNev added fixed - waiting release PR Committed and waiting deployment and removed fixed - waiting release PR Committed and waiting deployment labels Mar 8, 2023
@MSNev MSNev closed this as completed Mar 8, 2023
Copy link

github-actions bot commented Mar 8, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants