Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1094 #1096

Merged
merged 6 commits into from
Nov 4, 2019
Merged

Issue 1094 #1096

merged 6 commits into from
Nov 4, 2019

Conversation

aaronpowell
Copy link
Contributor

This addresses #1094 by doing typeof tests against globals to ensure they exist.

aaronpowell and others added 2 commits November 3, 2019 12:45
@aaronpowell @markwolff
Update extensions/applicationinsights-dependencies-js/src/ajax.ts
555e845 
Co-Authored-By: Mark Wolff <mrw00010@gmail.com>
@aaronpowell @markwolff
Update legacy/JavaScript/JavaScriptSDK/ajax/ajax.ts
add7360 
Co-Authored-By: Mark Wolff <mrw00010@gmail.com>
@aaronpowell
Copy link
Contributor Author

Thanks @markwolff, both those changes are actioned. Didn't realise xhr wasn't always detected as function, was it object? (I'm just curious)

And I can't believed I missed a === 🤦‍♂

@markwolff
Copy link
Contributor

@aaronpowell Yes I believe it was reported as an object for IE9 (and 10?), even though we can patch it in the same way

@markwolff markwolff merged commit a680478 into microsoft:master Nov 4, 2019
@aaronpowell aaronpowell deleted the aaronpowell/issue-1094 branch January 7, 2020 22:56
@snyk-bot snyk-bot mentioned this pull request Feb 14, 2020
Open
@MSNev MSNev linked an issue Apr 7, 2020 that may be closed by this pull request
[BUG] Server Side Rendering fails when using Gatsby #1094
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwolff markwolff markwolff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Server Side Rendering fails when using Gatsby
2 participants
@aaronpowell @markwolff