Enable and maintain compatibility for older browsers including IE8 #1075 #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
force-pushed
the
MSNev/IE8Compat
branch
from
76fd0db
to
16f189e
Compare
MSNev
commented
Oct 31, 2019
markwolff
requested review from
markwolff,
hectorhdzg,
xiao-lix and
ramthi
and removed request for
markwolff
markwolff
reviewed
Oct 31, 2019
markwolff
reviewed
Oct 31, 2019
xiao-lix
reviewed
Oct 31, 2019
MSNev
force-pushed
the
MSNev/IE8Compat
branch
from
16f189e
to
c4a625a
Compare
xiao-lix
reviewed
Nov 1, 2019
MSNev
force-pushed
the
MSNev/IE8Compat
branch
from
c4a625a
to
7fa9a85
Compare
markwolff
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
As an SDK there are numerous users which cannot control the browsers that customers use. As such we need to ensure that the SDK continues to work and does not break the JS execution when loaded in an older browser.
Describe the solution you'd like
As part of this we need to have the generated be compatible with ES3 and use either polyfil implementations or striped back emulation of any required ES5/6 supported features.