Update to TypeScript 4.x #1071 #1130

MSNev · 2019-12-04T00:52:32Z

Addresses #1071 and builds on Aaron's PR #1072

extensions/applicationinsights-analytics-js/src/JavaScriptSDK/ApplicationInsights.ts

shared/AppInsightsCommon/src/Util.ts

MSNev · 2019-12-19T19:28:42Z

We had a discussion this morning about this change and we have decided to delay this until later in 2020 as the last time we attempt to upgrade to Typescript v3 we broke people using Typescript v2.

As such the current plan is that we will introduce a major upgrade next year (bumping the AI version to v3) along with some other work to assist with code minification that could additionall cause breaking changes (due to hiding of internal properties and potentially changing of methods from class (prototype) based to defined as instance level (like properties) myFunction: (theargs) => result; and supply the implementation in the constructor vs myFunction(theArgs): result { ... }

hecflores · 2020-01-21T12:55:44Z

Question. Will the current version (not using typescript 3.x) cause issues with users using typescript 3.x?

MSNev · 2020-01-21T18:52:25Z

@hecflores No, the current version using TS v2 will work fine for anyone using TS 3+.

My understanding from talking with the team is that the issue is related the generated *.d.ts files by TS 3.x and users using TS 2.x. The team had previously upgraded to TS 3,x (and rolled back) due to breaking issues that where reported.

legacy/JavaScript/JavaScriptSDK/Sender.ts

extensions/applicationinsights-react-js/package.json

extensions/applicationinsights-angularplugin-js/Tests/test-app/package.json

MSNev · 2021-08-12T18:33:30Z

.github/workflows/react.yml

-    - run: npm install
-    - run: npm run build --if-present
-    - run: npm test
+    # - run: npm install


As part of this change React and React-native extensions are now built and tested as part of the main ci.yml flow, so once this is checked in we will be able to build, release and test these all together.

MSNev · 2021-08-12T18:34:04Z

.github/workflows/reactnative.yml

-    - name: Run tests for ReactNative plugin
-      working-directory: extensions/applicationinsights-react-native
-      run: npm test
+    # - name: Install root dependencies


As above, react-native is build and tested as part of the normal build again.

MSNev · 2021-08-12T18:35:18Z

extensions/applicationinsights-react-js/api-extractor.json

@@ -0,0 +1,361 @@
+/**


Add api-extractor to react as it's now part of the main build.

MSNev · 2021-08-12T18:37:00Z

extensions/applicationinsights-react-js/tsconfig.json

@@ -5,7 +5,7 @@
    "noImplicitAny": true,
    "module": "es6",
    "moduleResolution": "Node",
-    "target": "es3",
+    "target": "es5",


react doesn't work in IE, so this is a safe change (required for eslint validation)

MSNev · 2021-08-12T18:37:15Z

extensions/applicationinsights-react-js/src/useTrackEvent.ts

 import ReactPlugin from "./ReactPlugin";

+export type AIReactCustomEvent<T> = Dispatch<SetStateAction<T>>;


Required for eslint validation

MSNev · 2021-08-12T18:38:05Z

extensions/applicationinsights-react-native/Tests/Unit/src/reactnativeplugin.tests.ts

 import dynamicProto from '@microsoft/dynamicproto-js';

-export class ReactNativePluginTests extends TestClass {
+export class ReactNativePluginTests extends AITestClass {


Change reactnative tests to use the common test framework as it's now built and tested during the normal build.

MSNev · 2021-08-12T18:39:13Z

extensions/applicationinsights-react-native/Tests/Unit/src/reactnativeplugin.tests.ts

-                const autoCollectStub = this.sandbox.stub(this.plugin, '_collectDeviceInfo');
-                const autoCollectExceptionStub = this.sandbox.stub(this.plugin, '_setExceptionHandler', () => true);
+                const autoCollectStub = this.sandbox.stub(this.plugin as any, '_collectDeviceInfo');
+                const autoCollectExceptionStub = this.sandbox.stub(this.plugin as any, '_setExceptionHandler').callsFake(() => true);


Change required as part of bumping to the latest version of Sinon which removed the previous stub function

MSNev · 2021-08-12T18:39:46Z

extensions/applicationinsights-react-native/Tests/Unit/src/reactnativeplugin.tests.ts

@@ -175,21 +173,6 @@ export class ReactNativePluginTests extends TestClass {
    private _getDevice(plugin: any): any {
        return plugin._getDbgPlgTargets()[0];
    }
-
-    protected _disableDynProtoBaseFuncs() {


This is now in the common test framework class (AITestClass)

MSNev · 2021-08-12T18:40:30Z

extensions/applicationinsights-react-native/Tests/UnitTests.html

@@ -8,12 +8,12 @@
    <link rel="stylesheet" href="https://code.jquery.com/qunit/qunit-1.23.1.css">
    <script src="http://sinonjs.org/releases/sinon-2.3.8.js"></script>
    <script src="http://cdnjs.cloudflare.com/ajax/libs/require.js/2.2.0/require.js"></script>
-    <script src="../../../../common/Tests/Selenium/ModuleLoader.js"></script>
-    <script src="../../../../common/Tests/Selenium/SimpleSyncPromise.js"></script>
+    <script src="../../../common/Tests/Selenium/ModuleLoader.js"></script>


Required as re-organizing the test files to be the same as the main sku's and extensions

MSNev · 2021-08-12T18:41:36Z

extensions/applicationinsights-react-native/package.json

@@ -3,33 +3,43 @@
    "version": "2.3.5",
    "description": "Microsoft Application Insights React Native Plugin",
    "main": "dist-esm/index.js",
-    "types": "dist-esm/index.d.ts",
+    "types": "types/index.d.ts",


Changing so all packages are dropping files in the same way.

MSNev · 2021-08-12T18:44:26Z

extensions/applicationinsights-react-native/tsconfig.json

    "alwaysStrict": true,
    "suppressImplicitAnyIndexErrors": true,
    "allowSyntheticDefaultImports": true,
    "importHelpers": true,
    "noEmitHelpers": true,
    "forceConsistentCasingInFileNames": true,
    "declaration": true,
-    "declarationDir": "dist-esm",
+    "declarationDir": "extensions/applicationinsights-react-native/types",


Updated to match the package.json location

MSNev · 2021-08-12T18:45:16Z

rush.json

@@ -66,6 +65,16 @@
      "projectFolder": "extensions/applicationinsights-clickanalytics-js",
      "shouldPublish": true
    },
+    {


Add back react and react-native into the main build/test cycle

- Enable ESLint-Fix during compilation - Fold react and React Native projects back into main build

MSNev commented Dec 4, 2019

View reviewed changes

extensions/applicationinsights-analytics-js/src/JavaScriptSDK/ApplicationInsights.ts Outdated Show resolved Hide resolved

MSNev commented Dec 4, 2019

View reviewed changes

shared/AppInsightsCommon/src/Util.ts Outdated Show resolved Hide resolved

MSNev force-pushed the MSNev/UpgradeTypeScript branch 2 times, most recently from 3e4d406 to a4bfd0d Compare December 6, 2019 22:49

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 3db87b5 to a517584 Compare January 30, 2020 01:54

MSNev requested a review from a team as a code owner January 30, 2020 01:54

MSNev force-pushed the MSNev/UpgradeTypeScript branch from a517584 to 47714ae Compare January 30, 2020 20:36

MSNev commented Feb 3, 2020

View reviewed changes

legacy/JavaScript/JavaScriptSDK/Sender.ts Outdated Show resolved Hide resolved

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 47714ae to 862b1f1 Compare February 3, 2020 21:36

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 862b1f1 to 7fabb5c Compare February 29, 2020 00:10

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 7fabb5c to 0640dac Compare April 9, 2020 01:12

MSNev force-pushed the MSNev/UpgradeTypeScript branch 4 times, most recently from f2833df to 266ad6e Compare June 9, 2020 19:21

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 266ad6e to 85b8391 Compare July 9, 2020 02:07

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 85b8391 to e6e52fa Compare August 15, 2020 01:28

MSNev force-pushed the MSNev/UpgradeTypeScript branch 2 times, most recently from 60ba914 to 06329a8 Compare August 31, 2020 21:51

MSNev force-pushed the MSNev/UpgradeTypeScript branch 2 times, most recently from fca52cb to 9a1d0f1 Compare November 21, 2020 01:44

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 9a1d0f1 to 64c1cff Compare January 28, 2021 22:55

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 64c1cff to 6e5a638 Compare April 3, 2021 01:31

MSNev commented Apr 3, 2021

View reviewed changes

extensions/applicationinsights-react-js/package.json Outdated Show resolved Hide resolved

MSNev force-pushed the MSNev/UpgradeTypeScript branch 2 times, most recently from 9f4296f to 9e83e9b Compare April 28, 2021 20:17

MSNev commented Apr 28, 2021

View reviewed changes

extensions/applicationinsights-angularplugin-js/Tests/test-app/package.json Outdated Show resolved Hide resolved

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 1fad7aa to 8b02535 Compare August 4, 2021 23:01

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 8b02535 to 3f76e09 Compare August 12, 2021 17:51

MSNev requested review from hectorhdzg, Karlie-777, kryalama, ramthi and xiao-lix and removed request for a team August 12, 2021 18:22

MSNev added this to the 2.x.x (Next Release) milestone Aug 12, 2021

MSNev commented Aug 12, 2021

View reviewed changes

xiao-lix approved these changes Aug 16, 2021

View reviewed changes

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 3f76e09 to 9737d5b Compare August 16, 2021 22:35

MSNev added 3 commits August 16, 2021 15:39

Update to TypeScript 4.x #1071

15cbefc

- Enable ESLint-Fix during compilation - Fold react and React Native projects back into main build

Update new PerfMarkMeasure to TypeScript 4.x build

5e96f85

Missed updates from previous PR -- remove unused variables

a1fcfc9

MSNev force-pushed the MSNev/UpgradeTypeScript branch from 9737d5b to a1fcfc9 Compare August 16, 2021 23:06

MSNev merged commit f3f1a80 into master Aug 16, 2021

MSNev added the released - beta NPM label Aug 24, 2021

MSNev deleted the MSNev/UpgradeTypeScript branch November 13, 2021 01:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to TypeScript 4.x #1071 #1130

Update to TypeScript 4.x #1071 #1130

MSNev commented Dec 4, 2019

MSNev commented Dec 19, 2019

hecflores commented Jan 21, 2020

MSNev commented Jan 21, 2020

MSNev Aug 12, 2021

MSNev Aug 12, 2021

MSNev Aug 12, 2021

MSNev Aug 12, 2021

MSNev Aug 12, 2021

MSNev Aug 12, 2021

MSNev Aug 12, 2021

MSNev Aug 12, 2021

MSNev Aug 12, 2021

MSNev Aug 12, 2021 •

edited

Loading

MSNev Aug 12, 2021

MSNev Aug 12, 2021

		import ReactPlugin from "./ReactPlugin";

		export type AIReactCustomEvent<T> = Dispatch<SetStateAction<T>>;

Update to TypeScript 4.x #1071 #1130

Update to TypeScript 4.x #1071 #1130

Conversation

MSNev commented Dec 4, 2019

MSNev commented Dec 19, 2019

hecflores commented Jan 21, 2020

MSNev commented Jan 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MSNev Aug 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MSNev Aug 12, 2021 •

edited

Loading