[BUG]AppInsights not working in IE7 #1142 #1162

MSNev · 2020-01-18T00:14:00Z

Provide packaging rollup plugins to replace and detect non-ES3 included code.

MSNev · 2020-01-18T00:15:51Z

AISKU/rollup.config.js

@@ -31,7 +32,9 @@ const browserRollupConfigFactory = (isProduction, libVersion = '2') => {
      nodeResolve({
        browser: false,
        preferBuiltins: false
-      })
+      }),
+      es3Poly(),


New rollup plugins that replace some of the incompatible ES3 code and check that we are not including some of the easily detectable known methods.

MSNev · 2020-01-18T00:17:06Z

AISKU/src/Init.ts

@@ -13,7 +13,7 @@ function _logWarn(aiName:string, message:string) {
    // TODO: Find better place to warn to console when SDK initialization fails
    var _console = typeof console !== Undefined ? console : null;
    if (_console && _console.warn) {
-        _console.warn('Failed to initialize AppInsights JS SDK for instance ' + aiName + message);
+        _console.warn('Failed to initialize AppInsights JS SDK for instance ' + (aiName || '<unknown>') + ' - ' + message);


Just formatting this error a little better, which mostly occurs on when the environment doesn't contain "window" or "JSON" implementations.

MSNev · 2020-01-18T00:17:53Z

gruntfile.js

@@ -132,6 +132,16 @@ module.exports = function (grunt) {
                ],
                out: './channels/applicationinsights-channel-js/Tests/Selenium/aichannel.tests.js'
            },
+            rollupes3: {


Add new plugins to the build chain

MSNev · 2020-01-18T00:19:35Z

tools/rollup-es3/src/es3/Es3Check.ts

@@ -0,0 +1,73 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.


This is the es3Check() plugin

MSNev · 2020-01-18T00:19:49Z

tools/rollup-es3/src/es3/Es3Poly.ts

@@ -0,0 +1,141 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.


This is the es3Poly() plugin

MSNev · 2020-01-18T00:20:20Z

tools/rollup-es3/src/es3/Es3Tokens.ts

+// Licensed under the MIT License.
+import { IEs3CheckKeyword, IEs3Keyword } from "./Interfaces";
+
+export const defaultEs3Tokens:Array<IEs3Keyword> = [


The default keyword rules for es3Poly()

MSNev · 2020-01-18T00:20:40Z

tools/rollup-es3/src/es3/Es3Tokens.ts

+    }
+];
+
+export const defaultEs3CheckTokens:Array<IEs3CheckKeyword> = [


The default keyword rules for es3Check()

MSNev · 2020-01-18T00:21:18Z

tools/rollup-es3/src/es3/Es3Tokens.ts

+        funcNames: [ /Object\.(defineProperties)\(/g ],
+        errorMsg: "[%funcName%] is not supported in an ES3 environment, use a helper function or add explicit check for existence",
+        ignoreIds: [ 
+            "applicationinsights-react-js", // Don't break build if these exist in the final react extension


Ignoring react as the react code and included dependencies uses defineProperties

MSNev · 2020-01-18T00:22:17Z

tools/rollup-es3/src/es3/FormatError.ts

+import { padEnd, isNullOrWhitespace } from "./Utils";
+import { IEs3CheckKeyword, IEs3Keyword } from "./Interfaces";
+
+export function formatError(keyword:IEs3CheckKeyword|IEs3Keyword, funcName:string, errorMsg:string, code:string, pos:number, id:string, entry:string) {


Error formatter, it seems a bit over the top, but when it detects a failure this provides the context to help find the offending implementation.

MSNev

Self reviewed

markwolff · 2020-01-23T01:15:57Z

AISKU/package.json

+        "@microsoft/applicationinsights-properties-js": "2.4.0-beta"
+    },
+    "peerDependencies": {
+        "@microsoft/applicationinsights-rollup-es3" : "1.0.0",
        "tslib": "^1.9.3"


tslib should be a pure dependency

Moved as suggested

markwolff · 2020-01-23T01:16:19Z

AISKU/package.json

+        "@microsoft/applicationinsights-properties-js": "2.4.0-beta"
+    },
+    "peerDependencies": {
+        "@microsoft/applicationinsights-rollup-es3" : "1.0.0",


Does this need to be a peer dependency? Would it not work as a dev dependency?

Moved as suggested

markwolff · 2020-01-23T01:17:38Z

AISKULight/package.json

        "@microsoft/applicationinsights-common": "2.4.0-beta",
        "@microsoft/applicationinsights-channel-js": "2.4.0-beta",
        "@microsoft/applicationinsights-core-js": "2.4.0-beta"
    },
    "peerDependencies": {
-        "tslib": "^1.9.3"
+        "@microsoft/applicationinsights-rollup-es3" : "1.0.0"


Does this need to be a peer dependency?

Moved as suggested

markwolff · 2020-01-23T01:18:15Z

extensions/applicationinsights-analytics-js/package.json

+        "@microsoft/applicationinsights-common": "2.4.0-beta"
+    },
+    "peerDependencies": {
+        "@microsoft/applicationinsights-rollup-es3" : "1.0.0",


See other comments. I think this can be a dev dep

Moved as suggested

markwolff · 2020-01-23T01:18:34Z

extensions/applicationinsights-properties-js/package.json

+        "@microsoft/applicationinsights-common": "2.4.0-beta"
+    },
+    "peerDependencies": {
+        "@microsoft/applicationinsights-rollup-es3" : "1.0.0",
        "tslib": "^1.9.3"


see other tslib comments

Moved as suggested

markwolff · 2020-01-23T01:20:19Z

tools/rollup-es3/Tests/tsconfig.json

+        "target": "es5",
+        "alwaysStrict": true,
+        "declaration": true,
+        "lib": [ "dom", "es2015" ]


are these required?

Yes, the test project needs it's own tsconfig

Is dom and es2015 required? This does not exist on other tsconfig in this repo

Removed, but not sure while still listed here...

- Provide packaging rollup plugins to replace and detect non-ES3 included code. - Remove Es3 checks from reactive-native

MSNev requested a review from a team as a code owner January 18, 2020 00:14

MSNev commented Jan 18, 2020

View reviewed changes

MSNev force-pushed the MSNev/ES3Support branch 3 times, most recently from 2fbfcd5 to 2786af3 Compare January 21, 2020 21:47

markwolff reviewed Jan 23, 2020

View reviewed changes

MSNev force-pushed the MSNev/ES3Support branch 5 times, most recently from d21dcb2 to a31cd9f Compare January 28, 2020 00:04

[BUG]AppInsights not working in IE7 #1142

324a6d7

- Provide packaging rollup plugins to replace and detect non-ES3 included code. - Remove Es3 checks from reactive-native

MSNev force-pushed the MSNev/ES3Support branch from a31cd9f to 324a6d7 Compare January 28, 2020 18:44

markwolff approved these changes Jan 28, 2020

View reviewed changes

MSNev merged commit 7190261 into master Jan 28, 2020

snyk-bot mentioned this pull request Feb 22, 2020

[Snyk] Upgrade @microsoft/applicationinsights-web from 2.4.0 to 2.4.1 emilbolet/bolet.io-OLD#1

Merged

snyk-bot mentioned this pull request Mar 7, 2020

[Snyk] Upgrade @microsoft/applicationinsights-web from 2.4.1 to 2.4.4 emilbolet/bolet.io-OLD#7

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG]AppInsights not working in IE7 #1142 #1162

[BUG]AppInsights not working in IE7 #1142 #1162

MSNev commented Jan 18, 2020

MSNev Jan 18, 2020

MSNev Jan 18, 2020

MSNev Jan 18, 2020

MSNev Jan 18, 2020

MSNev Jan 18, 2020

MSNev Jan 18, 2020

MSNev Jan 18, 2020

MSNev Jan 18, 2020

MSNev Jan 18, 2020

MSNev left a comment

markwolff Jan 23, 2020

MSNev Jan 23, 2020

markwolff Jan 23, 2020

MSNev Jan 23, 2020

markwolff Jan 23, 2020

MSNev Jan 23, 2020

markwolff Jan 23, 2020

MSNev Jan 23, 2020

markwolff Jan 23, 2020

MSNev Jan 23, 2020

markwolff Jan 23, 2020

MSNev Jan 23, 2020

markwolff Jan 28, 2020

MSNev Jan 28, 2020

		@@ -0,0 +1,73 @@
		// Copyright (c) Microsoft Corporation. All rights reserved.

		@@ -0,0 +1,141 @@
		// Copyright (c) Microsoft Corporation. All rights reserved.

[BUG]AppInsights not working in IE7 #1142 #1162

[BUG]AppInsights not working in IE7 #1142 #1162

Conversation

MSNev commented Jan 18, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MSNev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment