Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typos #1171

Merged
merged 3 commits into from
Jan 28, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ Most configuration fields are named such that they can be defaulted to falsey. A
| sessionExpirationMs | 86400000 | A session is logged if it has continued for this amount of time in milliseconds. Default is 24 hours |
| maxBatchSizeInBytes | 10000 | Max size of telemetry batch. If a batch exceeds this limit, it is immediately sent and a new batch is started |
| maxBatchInterval | 15000 | How long to batch telemetry for before sending (milliseconds) |
| disableExceptionTracking | false | If true, exceptions are no autocollected. Default is false. |
| disableExceptionTracking | false | If true, exceptions are not autocollected. Default is false. |
| disableTelemetry | false | If true, telemetry is not collected or sent. Default is false. |
| enableDebug | false | If true, **internal** debugging data is thrown as an exception **instead** of being logged, regardless of SDK logging settings. Default is false. <br>***Note:*** Enabling this setting will result in dropped telemetry whenever an internal error occurs. This can be useful for quickly identifying issues with your configuration or usage of the SDK. If you do not want to lose telemetry while debugging, consider using `consoleLoggingLevel` or `telemetryLoggingLevel` instead of `enableDebug`. |
| loggingLevelConsole | 0 | Logs **internal** Application Insights errors to console. <br>0: off, <br>1: Critical errors only, <br>2: Everything (errors & warnings) |
Expand Down
8 changes: 4 additions & 4 deletions shared/AppInsightsCommon/src/Interfaces/IConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export interface IConfig {
samplingPercentage?: number;

/**
* @description
* @description If true, on a pageview,the previous instrumented page's view time is tracked and sent as telemetry and a new timer is started for the current pageview. Default is false.
* @type {boolean}
* @memberof IConfig
*/
Expand Down Expand Up @@ -263,7 +263,7 @@ export interface IConfig {
appId?: string;

/**
* @description If true, the SDK will add two headers ('Request-Id' and 'Request-Context') to all CORS requests tocorrelate outgoing AJAX dependencies with corresponding requests on the server side. Default is false
* @description If true, the SDK will add two headers ('Request-Id' and 'Request-Context') to all CORS requests to correlate outgoing AJAX dependencies with corresponding requests on the server side. Default is false
* @type {boolean}
* @memberof IConfig
* @defaultValue false
Expand All @@ -287,15 +287,15 @@ export interface IConfig {
enableRequestHeaderTracking?: boolean;

/**
* @description An optional value that will track Resonse Header through trackDependency function.
* @description An optional value that will track Response Header through trackDependency function.
* @type {boolean}
* @memberof IConfig
* @defaultValue false
*/
enableResponseHeaderTracking?: boolean;

/**
* @description An optional value that will track Resonse Error data through trackDependency function.
* @description An optional value that will track Response Error data through trackDependency function.
* @type {boolean}
* @memberof IConfig
* @defaultValue false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { _InternalLogMessage, DiagnosticLogger } from "./DiagnosticLogger";
"use strict";

export class AppInsightsCore extends BaseCore implements IAppInsightsCore {
public baseCore: BaseCore;
public config: IConfiguration;
public logger: IDiagnosticLogger;

Expand Down