[BUG] Typescript build with 2.4.0 breaks #1173 #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
commented
Jan 29, 2020
MSNev
commented
Jan 29, 2020
AISKU/Tests/package.json
Outdated
| @@ -0,0 +1,41 @@ | |||
| { | |||
| "name": "@microsoft/applicationinsights-web-tests", | |||
There was a problem hiding this comment.
Adding new package.json so the tests reference the generated module.
MSNev
commented
Jan 29, 2020
| @@ -85,7 +85,7 @@ module Microsoft.ApplicationInsights { | |||
| private instrumentOpen() { | |||
| var originalOpen = XMLHttpRequest.prototype.open; | |||
| var ajaxMonitorInstance = this; | |||
| XMLHttpRequest.prototype.open = function (method, url, async) { | |||
| XMLHttpRequest.prototype.open = function (method, url, async?) { | |||
There was a problem hiding this comment.
Change backported from my TypeScript 3.7.x upgrade PR (Where I tested these changes) as the async is really optional.
MSNev
commented
Jan 29, 2020
| @@ -232,7 +232,7 @@ export class Util { | |||
| const keys = []; | |||
|
|
|||
| if (Util.canUseSessionStorage()) { | |||
| for (const key in getGlobalInst("sessionStorage")) { | |||
| for (const key in getGlobalInst<any>("sessionStorage")) { | |||
There was a problem hiding this comment.
Another TS 3.7.x required syntax change.
Note: This PR is not changing that the version of TS being used (2.5.3)
MSNev
commented
Jan 29, 2020
| @@ -137,7 +137,7 @@ export class ProcessTelemetryContext implements IProcessTelemetryContext { | |||
| /** | |||
| * Create a new context using the core and config from the current instance | |||
| */ | |||
| public createNew: (plugins?:IPlugin[], startAt?:IPlugin) => IProcessTelemetryContext; | |||
| public createNew: (plugins?:IPlugin[]|ITelemetryPluginChain, startAt?:IPlugin) => IProcessTelemetryContext; | |||
There was a problem hiding this comment.
This was the actual implementation failure
MSNev
force-pushed
the
MSNev/TypoFixesForTS3.7
branch
from
86bf33f
to
8dafbc6
Compare
xiao-lix
approved these changes
Jan 30, 2020
markwolff
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #1173 where the declaration of the methods does not match the actual implementation.