Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the generated modules to extend the namespace defined by "name" in rollup config -- rather than always replace. #1311

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

MSNev
Copy link
Collaborator

@MSNev MSNev commented Jul 2, 2020

No description provided.

… in rollup config -- rather than always replace.
@MSNev MSNev requested a review from a team as a code owner July 2, 2020 01:17
@markwolff
Copy link
Contributor

I'm curious how we haven't affected the Microsoft namespace already. Are we also overwriting this namespace? This wouldn't be fixed by this config change right?

@MSNev
Copy link
Collaborator Author

MSNev commented Jul 2, 2020

It because, this change only affects the final element of the name
Without the extend
(factory((global.Microsoft = global.Microsoft || {}, global.Microsoft.ApplicationInsights = {})));

With the extend
(factory((global.Microsoft = global.Microsoft || {}, global.Microsoft.ApplicationInsights = global.Microsoft.ApplicationInsights || {})));

So if we set the name to just "Microsoft" then we would have 😃

@MSNev MSNev merged commit 04bca41 into master Jul 2, 2020
@MSNev MSNev added this to the 2.5.6 milestone Jul 2, 2020
@MSNev MSNev deleted the MSNev/SharedGlobalName branch August 15, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants