fixed various issues and updating to beta-2 #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwolff
reviewed
Jul 23, 2020
| container.style.left = '0'; | ||
| container.style.bottom = '0'; | ||
| container.style.right = '0'; | ||
| container.style.width = "300px"; |
| @@ -0,0 +1 @@ | |||
| presentation/ | |||
| if (key.substring(0, 1) === '_') { continue; } | ||
| if (CoreUtils.isFunction(ext[key])) { | ||
| protoFns.push(key); | ||
| for (let i = 0; i < trackers.length; i++) { |
There was a problem hiding this comment.
Can for ... of be used here?
There was a problem hiding this comment.
Or better use the arrForEach() helper
Comment on lines
182
to
183
| console.log(permStyle(prefix)); | ||
| console.log(permStyle(prefix).substring(1000)); |
There was a problem hiding this comment.
+1 - The console is actually not defined by some browsers unless the dev console is open. So it should be checking whether the console and console.log exist before trying to use. --i.e.create a helper function to do the logging rather than always do the checks (when you want / need to log to the console)
MSNev
reviewed
Jul 29, 2020
extensions/applicationinsights-debugplugin-js/src/DebugPlugin.ts
Outdated
Show resolved
Hide resolved
fudgepop01
force-pushed
the
MSDAReba/debugplugin
branch
from
1a05973
to
b00069b
Compare
MSNev
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will be updating the design and adding features to beta version 2.
Features include two types of filters and an updated look.