- AppInsightsCore: Enable setting NotificationManager during initialization #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
Jul 29, 2020
MSNev
commented
- Refactor code to provide better tree shaking and minification of generated code Refactor code to provide better tree shaking and minification of generated code #1076
MSNev
requested review from
fudgepop01,
markwolff,
ramthi,
xiao-lix,
hectorhdzg and
kryalama
MSNev
force-pushed
the
MSNev/SharedNotificationManager
branch
from
0319652
to
39375a5
Compare
…zation - Refactor code to provide better tree shaking and minification of generated code #1076
MSNev
force-pushed
the
MSNev/SharedNotificationManager
branch
from
39375a5
to
25b26ed
Compare
markwolff
reviewed
Jul 31, 2020
| @@ -158,7 +158,7 @@ export class CoreUtils { | |||
| * @param {any} value - Value to be checked. | |||
| * @return {boolean} True if the value is a boolean, false otherwise. | |||
| */ | |||
| public static isBoolean(value: any): boolean { | |||
| public static isBoolean(value: any): value is boolean { | |||
markwolff
reviewed
Jul 31, 2020
| const subject = this.getSubject(initializer, name); | ||
| // this.name = name; | ||
| // this.initializer = initializer; | ||
| // } |
There was a problem hiding this comment.
will all of these be added back in?
There was a problem hiding this comment.
As some point we should... But as they where never used I just commented them out for now over just straight out deleting.
markwolff
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.