Instrumentation Key validation #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs taken from breeze repo(https://dev.azure.com/msazure/One/_git/Mgmt-AppInsights-Breeze)
The definition of a VALID instrumentation key is as follows:
Not none
Not empty
Every character is a hex character [0-9a-f]
32 characters are separated into 5 sections via 4 dashes
First section has 8 characters
Second section has 4 characters
Third section has 4 characters
Fourth section has 4 characters
Fifth section has 12 characters
As of now we are throwing an internal error of severity 'Critical'. This will not break existing users test cases with invalid ikey.
Also customers can disable ikey validation using disableInstrumentaionKeyValidation config set to true.