-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stamp Specific endpoint changes #1474
Conversation
Note: it looks like the test pass failed for the same issue I talked about in standup today. My PR #1469 has the temporary fix for this -- it's a bit big though, but if you have a chance to review would be good. |
|
||
// check if the xhr's responseURL is same as endpoint url | ||
// TODO after 10 redirects force send telemetry with'redirect=false' as query parameter. | ||
if(xhr.responseURL !== _self._senderConfig.endpointUrl()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should check that
- the responseURL is not empty and look valid (some XHR polyfill's might not set this etc)
Additional considerations.
- Do we want to retry the original URL if the redirected one also continues to fail
- Do we only want to update on a successful send (200-299 response status code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think updating the url only after we get a successful xhr send is a better approach.
Fixes for the test failures (dts generation) are now checked in, to rebasing should resolve the test issues |
@@ -386,6 +400,11 @@ export class Sender extends BaseTelemetryPlugin implements IChannelControlsAI { | |||
_InternalMessageId.TransmissionFailed, `. Offline - Response Code: ${xhr.status}. Offline status: ${Offline.isOffline()}. Will retry to send ${payload.length} items.`); | |||
} | |||
} else { | |||
|
|||
// check if the xhr's responseURL is same as endpoint url | |||
// TODO after 10 redirects force send telemetry with 'redirect=false' as query parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the timeframe for this todo?
Overview
Internal Change spec
//TODO